From: Yuri <yuri@rawbw.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: git quietly fails on https:// URL, https errors are never reported to user
Date: Thu, 16 Jan 2014 11:28:11 -0800 [thread overview]
Message-ID: <52D832CB.1010403@rawbw.com> (raw)
In-Reply-To: <20140116180310.GA27180@sigill.intra.peff.net>
On 01/16/2014 10:03, Jeff King wrote:
> We used to print "Reading from helper 'git-remote-https' failed" in this
> instance. But in the majority of cases, remote-https has printed a
> useful message already to stderr, and the extra line just confused
> people. The downside, as you noticed, is that when the helper dies
> without printing an error, the user is left with no message.
In my case it was some random misconfiguration of the libraries handling
https that caused them to fail in some way silently. Full update of the
supporting libraries fixed this. But previous forced git update didn't
fix it.
I think your should bring back this printout. Errors only happen in a
very low percentage of cases, and printing some more would be very
helpful for troubleshooting. I am not sure what happened in
git-remote-https, stream may have looked legit to it, or maybe it got
some error from the supporting libraries and didn't report it. I can't
tell now because I updated and the problem is gone.
Yuri
next prev parent reply other threads:[~2014-01-16 19:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 12:27 git quietly fails on https:// URL, https errors are never reported to user Yuri
2014-01-16 18:03 ` Jeff King
2014-01-16 19:28 ` Yuri [this message]
2014-01-17 9:40 ` Yuri
2014-01-17 19:43 ` Junio C Hamano
2014-01-17 20:13 ` Jeff King
2014-01-17 20:18 ` Jeff King
2014-01-17 20:39 ` Yuri
2014-01-17 21:10 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D832CB.1010403@rawbw.com \
--to=yuri@rawbw.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).