From: Sebastian Schuberth <sschuberth@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Christian Couder <christian.couder@gmail.com>
Subject: Re: [PATCH v2 1/4] Consistently use the term "builtin" instead of "internal command"
Date: Wed, 22 Jan 2014 22:08:45 +0100 [thread overview]
Message-ID: <52E0335D.3090408@gmail.com> (raw)
In-Reply-To: <CAHGBnuO+MT4pZHD8AiQ5mFU8bDwoFSgaCyxUzL572YVstCerqA@mail.gmail.com>
On 02.01.2014 22:05, Sebastian Schuberth wrote:
>> would just leave me wondering "I never claimed it was built-in; what's
>> going on?" I think it would be simplest to keep it as
>>
>> $ git whatever
>> fatal: cannot handle "whatever" internally
>>
>> which at least makes it clear that this is a low-level error.
>
> Right, I'll change this in a re-roll (using single-quotes for the command name).
Sorry for not coming up with the re-roll until now, and now it's too
late to fixup the commit as it's already on master (3f784a4). Since this
is just a minor wording issue I'll not follow this up anymore.
--
Sebastian Schuberth
next prev parent reply other threads:[~2014-01-22 21:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-02 16:12 [PATCH v2 0/4] Sebastian Schuberth
2014-01-02 16:15 ` [PATCH v2 1/4] Consistently use the term "builtin" instead of "internal command" Sebastian Schuberth
2014-01-02 20:31 ` Jonathan Nieder
2014-01-02 21:05 ` Sebastian Schuberth
2014-01-22 21:08 ` Sebastian Schuberth [this message]
2014-01-02 16:16 ` [PATCH v2 2/4] Call load_command_list() only when it is needed Sebastian Schuberth
2014-01-02 16:17 ` [PATCH v2 3/4] Speed up is_git_command() by checking early for internal commands Sebastian Schuberth
2014-01-02 19:41 ` Junio C Hamano
2014-01-03 15:44 ` Jeff King
2014-01-03 18:00 ` Junio C Hamano
2014-01-03 16:49 ` Kent R. Spillner
2014-01-05 13:42 ` Sebastian Schuberth
2014-01-22 21:05 ` Sebastian Schuberth
2014-01-02 16:17 ` [PATCH v2 4/4] Move builtin-related implementations to a new builtin.c file Sebastian Schuberth
2014-01-02 19:43 ` Junio C Hamano
2014-01-02 20:58 ` Sebastian Schuberth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E0335D.3090408@gmail.com \
--to=sschuberth@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).