From: Siddharth Agarwal <sid0@fb.com>
To: <git@vger.kernel.org>
Subject: WIth git-next, writing bitmaps fails when keep files are present
Date: Wed, 22 Jan 2014 18:38:57 -0800 [thread overview]
Message-ID: <52E080C1.4030402@fb.com> (raw)
Running git-next, writing bitmap indexes fails if a keep file is present
from an earlier pack.
With git at b139ac2, the following commands demonstrate the problem:
git init test
cd test
touch a
git add a
git commit -m "a"
git repack -ad # generate a pack file
for f in .git/objects/pack/*.pack; touch ${f/%pack/keep} # mark it as
to keep
touch b
git add b
git commit -m "b"
git repack -adb
This fails at the bitmap writing stage with something like:
Counting objects: 2, done.
Delta compression using up to 24 threads.
Compressing objects: 100% (2/2), done.
Writing objects: 100% (2/2), done.
fatal: Failed to write bitmap index. Packfile doesn't have full closure
(object 7388a015938147155b600eaacc59af6e78c75e5a is missing)
In our case we have .keep files lying around from ages ago (possibly due
to kill -9s run on the server). It also means that running repack -a
with bitmap writing enabled on a repo becomes problematic if a fetch is
run concurrently.
Even if we practice good .keep hygiene, this seems like a bug in git
that should be fixed.
next reply other threads:[~2014-01-23 2:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 2:38 Siddharth Agarwal [this message]
2014-01-23 20:36 ` WIth git-next, writing bitmaps fails when keep files are present Siddharth Agarwal
2014-01-23 22:52 ` [PATCH] pack-objects: turn off bitmaps when skipping objects Jeff King
2014-01-23 23:45 ` Siddharth Agarwal
2014-01-23 23:53 ` Siddharth Agarwal
2014-01-24 2:28 ` Jeff King
2014-01-24 2:44 ` Siddharth Agarwal
2014-01-28 6:09 ` [PATCH] repack: add `repack.honorpackkeep` config var Jeff King
2014-01-28 9:21 ` Junio C Hamano
2014-02-24 8:24 ` Jeff King
2014-02-24 19:10 ` Junio C Hamano
2014-02-26 10:13 ` Jeff King
2014-02-26 20:30 ` Junio C Hamano
2014-02-27 11:27 ` Jeff King
2014-02-27 18:04 ` Junio C Hamano
2014-02-28 8:55 ` Jeff King
2014-02-28 17:09 ` Nasser Grainawi
2014-03-01 6:05 ` Jeff King
2014-03-03 19:12 ` Shawn Pearce
2014-02-28 18:45 ` Junio C Hamano
2014-03-01 5:43 ` Jeff King
2014-03-03 18:13 ` Junio C Hamano
2014-03-03 18:15 ` Jeff King
2014-03-03 19:51 ` Junio C Hamano
2014-03-03 20:04 ` Jeff King
2014-01-23 23:56 ` [PATCH] pack-objects: turn off bitmaps when skipping objects Vicent Martí
2014-01-24 2:26 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E080C1.4030402@fb.com \
--to=sid0@fb.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).