From: Michael Haggerty <mhagger@alum.mit.edu>
To: Michael Haggerty <mhagger@alum.mit.edu>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Kent R. Spillner" <kspillner@acm.org>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
git@vger.kernel.org, "Johannes Sixt" <j.sixt@viscovery.net>,
"René Scharfe" <l.s.r@web.de>, "Jeff King" <peff@peff.net>
Subject: Re: [PATCH 0/3] Add a function skip_prefix_if_present()
Date: Wed, 05 Feb 2014 07:55:09 +0100 [thread overview]
Message-ID: <52F1E04D.3090208@alum.mit.edu> (raw)
In-Reply-To: <1391581517-8586-1-git-send-email-mhagger@alum.mit.edu>
On 02/05/2014 07:25 AM, Michael Haggerty wrote:
> These patches apply on top of gitster/nd/more-skip-prefix.
>
> I noticed that Duy's new function skip_prefix_defval() was mostly
> being called with its first and third arguments the same. So
> introduce a function skip_prefix_if_present() that implements this
> pattern.
I see I should have read the whole previous thread [1] before firing off
this patch series. What I learned when I read it just now:
* Johannes Sixt didn't think changes like the following improve
readability:
> - if (starts_with(arg, "--upload-pack=")) {
> - args.uploadpack = arg + 14;
> + if ((optarg = skip_prefix(arg, "--upload-pack=")) != NULL) {
> + args.uploadpack = optarg;
* René Scharfe submitted a patch to use a function parse_prefix()
(originally suggested by Peff) instead of Duy's suggested approach:
http://article.gmane.org/gmane.comp.version-control.git/239569
His patch appears to have been overlooked.
* Duy seemed to offer to rewrite his patch series, but I don't think
that it has happened yet.
And then the conversation was drowned by Christmas eggnog.
I don't have a strong feeling about (Duy's proposal plus my patches) vs.
(René's parse_prefix() approach). But I definitely *do* like the idea
of getting rid of all those awkward magic numbers everywhere.
Michael
[1]
http://thread.gmane.org/gmane.comp.version-control.git/239438/focus=239569
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
next prev parent reply other threads:[~2014-02-05 6:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 6:25 [PATCH 0/3] Add a function skip_prefix_if_present() Michael Haggerty
2014-02-05 6:25 ` [PATCH 1/3] Add and use " Michael Haggerty
2014-02-05 6:25 ` [PATCH 2/3] diff_scoreopt_parse(): use skip_prefix_if_present() Michael Haggerty
2014-02-05 6:25 ` [PATCH 3/3] rev_is_head(): use skip_prefix() Michael Haggerty
2014-02-05 6:55 ` Michael Haggerty [this message]
2014-02-05 17:26 ` [PATCH 0/3] Add a function skip_prefix_if_present() Jeff King
2014-02-06 12:19 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F1E04D.3090208@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=kspillner@acm.org \
--cc=l.s.r@web.de \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).