git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: Is GGG mislabeling topics?
Date: Thu, 2 Feb 2023 15:20:24 +0100 (CET)	[thread overview]
Message-ID: <52c9ed08-43c3-80c6-32f6-42209b799af6@gmx.de> (raw)
In-Reply-To: <xmqqpmba1ld4.fsf@gitster.g>

Hi Junio,

On Thu, 19 Jan 2023, Junio C Hamano wrote:

> These comments from GGG bot
>
>     https://github.com/git/git/pull/1435#issuecomment-1386301994
>     https://github.com/git/git/pull/1435#issuecomment-1386302018
>
> add 'next' and 'seen' labels, citing merges e3ead5f and c52b021
> respectively, but these merges are of a topic that has little to do
> with this pull request (#1435).  Is this expected?

Since I could not make `amlog` work reliably for GitGitGadget (and you
will recall that it was not for lack of trying, not by _any_ stretch of
imagination, I really, really put in a few weeks and it just turned out
that there was no way to come up with a 100% correct record of mappings
between patches on the Git mailing list and the commits in git/git), the
best I could do was to use `range-diff` to identify which patches made it
upstream, and what the upstream OIDs are.

What you see in action is that this is imperfect. Because in the absence
of actual git/git commits that correspond to the GitGitGadget Pull
Requests' commits, `range-diff` will even identify replacements or
alternative patches as the git/git commits corresponding to the PR.

I don't see how this could be made robust without forcing you to adopt
different processes than you are using right now.

Ciao,
Johannes

  reply	other threads:[~2023-02-02 14:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-19 17:32 Is GGG mislabeling topics? Junio C Hamano
2023-02-02 14:20 ` Johannes Schindelin [this message]
2023-02-02 17:06   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52c9ed08-43c3-80c6-32f6-42209b799af6@gmx.de \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).