From: Derrick Stolee <derrickstolee@github.com>
To: Victoria Dye via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Cc: gitster@pobox.com, phillip.wood123@gmail.com,
jonathantanmy@google.com, Taylor Blau <me@ttaylorr.com>,
Victoria Dye <vdye@github.com>
Subject: Re: [PATCH v2 0/5] Skip 'cache_tree_update()' when 'prime_cache_tree()' is called immediate after
Date: Thu, 10 Nov 2022 12:26:31 -0500 [thread overview]
Message-ID: <52f94376-bd05-9470-3804-4fcbc5751d18@github.com> (raw)
In-Reply-To: <pull.1411.v2.git.1668045438.gitgitgadget@gmail.com>
On 11/9/2022 8:57 PM, Victoria Dye via GitGitGadget wrote:
> Changes since V1
> ================
>
> * Rewrote 'p0090' to more accurately and reliably test 'prime_cache_tree()'
> vs. 'cache_tree_update()'.
> * Moved iterative cache tree update out of C and into the shell tests (to
> avoid potential runtime optimizations)
> * Added a "control" test to document how much of the execution time is
> startup overhead
> * Added tests demonstrating performance in partially-invalid cache trees.
> * Fixed the use of 'prime_cache_tree()' in 'test-tool cache-tree', changing
> it from using the tree at HEAD to the current cache tree.
I did a re-read of this series and it looks good to me.
Thanks for doing this investigation!
-Stolee
next prev parent reply other threads:[~2022-11-10 17:26 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 22:44 [PATCH 0/5] Skip 'cache_tree_update()' when 'prime_cache_tree()' is called immediate after Victoria Dye via GitGitGadget
2022-11-08 22:44 ` [PATCH 1/5] cache-tree: add perf test comparing update and prime Victoria Dye via GitGitGadget
2022-11-10 7:23 ` SZEDER Gábor
2022-11-08 22:44 ` [PATCH 2/5] unpack-trees: add 'skip_cache_tree_update' option Victoria Dye via GitGitGadget
2022-11-08 22:44 ` [PATCH 3/5] reset: use " Victoria Dye via GitGitGadget
2022-11-08 22:44 ` [PATCH 4/5] read-tree: " Victoria Dye via GitGitGadget
2022-11-08 22:44 ` [PATCH 5/5] rebase: " Victoria Dye via GitGitGadget
2022-11-09 15:23 ` [PATCH 0/5] Skip 'cache_tree_update()' when 'prime_cache_tree()' is called immediate after Derrick Stolee
2022-11-09 22:18 ` Victoria Dye
2022-11-10 14:44 ` Derrick Stolee
2022-11-09 23:01 ` Taylor Blau
2022-11-10 1:57 ` [PATCH v2 " Victoria Dye via GitGitGadget
2022-11-10 1:57 ` [PATCH v2 1/5] cache-tree: add perf test comparing update and prime Victoria Dye via GitGitGadget
2022-11-10 1:57 ` [PATCH v2 2/5] unpack-trees: add 'skip_cache_tree_update' option Victoria Dye via GitGitGadget
2022-11-10 1:57 ` [PATCH v2 3/5] reset: use " Victoria Dye via GitGitGadget
2022-11-10 1:57 ` [PATCH v2 4/5] read-tree: " Victoria Dye via GitGitGadget
2022-11-10 1:57 ` [PATCH v2 5/5] rebase: " Victoria Dye via GitGitGadget
2022-11-10 14:40 ` Phillip Wood
2022-11-10 18:19 ` Victoria Dye
2022-11-10 2:12 ` [PATCH v2 0/5] Skip 'cache_tree_update()' when 'prime_cache_tree()' is called immediate after Taylor Blau
2022-11-10 17:26 ` Derrick Stolee [this message]
2022-11-10 19:06 ` [PATCH v3 " Victoria Dye via GitGitGadget
2022-11-10 19:06 ` [PATCH v3 1/5] cache-tree: add perf test comparing update and prime Victoria Dye via GitGitGadget
2022-11-10 19:06 ` [PATCH v3 2/5] unpack-trees: add 'skip_cache_tree_update' option Victoria Dye via GitGitGadget
2022-11-10 19:06 ` [PATCH v3 3/5] reset: use " Victoria Dye via GitGitGadget
2022-11-10 19:06 ` [PATCH v3 4/5] read-tree: " Victoria Dye via GitGitGadget
2022-11-10 19:06 ` [PATCH v3 5/5] rebase: " Victoria Dye via GitGitGadget
2022-11-10 19:50 ` [PATCH v3 0/5] Skip 'cache_tree_update()' when 'prime_cache_tree()' is called immediate after SZEDER Gábor
2022-11-10 20:54 ` Victoria Dye
2022-11-11 2:50 ` Taylor Blau
2022-11-14 0:08 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52f94376-bd05-9470-3804-4fcbc5751d18@github.com \
--to=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=me@ttaylorr.com \
--cc=phillip.wood123@gmail.com \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).