From: Michael J Gruber <git@grubix.eu>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Adam Dinwoodie <adam@dinwoodie.org>,
Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: Unexpected pass for t6120-describe.sh on cygwin
Date: Wed, 13 Sep 2017 11:08:13 +0200 [thread overview]
Message-ID: <52f990d5-cdac-b516-269c-acbb68897e6e@grubix.eu> (raw)
In-Reply-To: <alpine.DEB.2.21.1.1709121538360.4132@virtualbox>
Johannes Schindelin venit, vidit, dixit 12.09.2017 15:39:
> Hi Ramsay,
>
> On Sat, 9 Sep 2017, Ramsay Jones wrote:
>
>> I ran the test-suite on the 'pu' branch last night (simply because that
>> was what I had built at the time!), which resulted in a PASS, but t6120
>> was showing a 'TODO passed' for #52.
>>
>> This is a test introduced by Michael's 'mg/name-rev-tests-with-short-stack'
>> branch, which uses 'ulimit -s' to try and force a stack overflow.
>> Unfortunately, 'ulimit -s' seems to have no effect on cygwin. I created
>> a test program (see below) to eat up the stack and tried running it with
>> various ulimit values (128, 12, 8), but it always seg-faulted at the
>> same stack-frame. (after using approx 2MB stack space).
>>
>> So, it looks like all ULIMIT_STACK_SIZE tests need to be disabled
>> on cygwin. I also wonder about the ULIMIT_FILE_DESCRIPTORS tests, but
>> haven't looked into it.
>>
>> Given that 'ulimit' is a bash built-in, this may also be a problem on
>> MinGW and Git-For-Windows, but I can't test on those platforms.
>
> It is.
Thanks.
I just dug something up from an old cygwin list post. Could you please
try and report on the following (cygwin, MinGW):
ulimit -s
ulimit -s 4096 # anything lower than the value from above
ulimit -s
bash -c "ulimit -s"
My suspicion from that post is that ulimit affects the sub shell only -
if yes, running a test inside the sub shell to confirm whether the
setting is in effect would be great, of course. /usr/bin/echo $(seq
100000) or such does the job on Linux (with stack limit 128), but I
don't know whether this is portably reliable.
If ulimit on these platforms has no effect but does not lie about the
value either it's a simple prerequisite test (test ulimit present, if
yes set and get and compare the stack size values).
Michael
next prev parent reply other threads:[~2017-09-13 9:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-09 13:13 Unexpected pass for t6120-describe.sh on cygwin Ramsay Jones
2017-09-10 12:27 ` Michael J Gruber
2017-09-10 16:58 ` Ramsay Jones
2017-09-11 10:31 ` Adam Dinwoodie
2017-09-11 22:17 ` Ramsay Jones
2017-09-11 17:47 ` Jeff King
2017-09-12 13:39 ` Johannes Schindelin
2017-09-13 9:08 ` Michael J Gruber [this message]
2017-09-13 13:11 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52f990d5-cdac-b516-269c-acbb68897e6e@grubix.eu \
--to=git@grubix.eu \
--cc=Johannes.Schindelin@gmx.de \
--cc=adam@dinwoodie.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).