From: Jens Lehmann <Jens.Lehmann@web.de>
To: Semyon Perepelitsa <semaperepelitsa@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH v2 3/3] push: Add the --no-recurse-submodules option
Date: Thu, 20 Feb 2014 13:12:34 +0000 [thread overview]
Message-ID: <5305FF42.9000402@web.de> (raw)
In-Reply-To: <A67F2B72-5398-4035-B79B-0568CA4BB0B4@gmail.com>
Hi Semyon,
Am 18.02.2014 18:49, schrieb Semyon Perepelitsa:
> I noticed the option in the man-page but there is still no configuration option available. Did you forget to add it after all?
Nope, we just didn't implement it yet. ;-)
It's one of the topics on my submodule ToDo list:
https://github.com/jlehmann/git-submod-enhancements/wiki
> Right now --recurse-submodules has little use by itself as the problem it solves is forgetting to push a submodule which is no different from forgetting to specify the option.
I'm currently busy working on another submodule related topic. But
if you are interested, adding the "fetch.recurseSubmodules" config
option in be254a0e and the "submodule.<name>.fetchRecurseSubmodules"
option in c1a3c364 should be good examples of how to add the
"push.recurseSubmodules" and "submodule.<name>.pushRecurseSubmodules"
config options.
I'll be glad to help in bringing this topic forward by discussing
ideas and reviewing patches. And I believe we should change the
default behavior of push (which is currently quiet about unpushed
submodule commits as you noticed) to either "check" or "on-demand"
(with my preference currently being slightly on the former, but I'm
happy to be convinced otherwise ;-).
Thanks
Jens
next prev parent reply other threads:[~2014-02-20 13:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 17:49 [PATCH v2 3/3] push: Add the --no-recurse-submodules option Semyon Perepelitsa
2014-02-20 13:12 ` Jens Lehmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-07-27 18:10 [PATCH v2 0/3] check for unpushed remotes in submodules Fredrik Gustafsson
2011-07-27 18:10 ` [PATCH v2 3/3] push: Add the --no-recurse-submodules option Fredrik Gustafsson
2011-07-28 20:05 ` Junio C Hamano
2011-07-28 22:22 ` Jens Lehmann
2011-07-29 20:19 ` Jens Lehmann
2011-08-01 1:16 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5305FF42.9000402@web.de \
--to=jens.lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=semaperepelitsa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).