From: Michael Haggerty <mhagger@alum.mit.edu>
To: David Kastrup <dak@gnu.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] cache_tree_find(): remove redundant check in while condition
Date: Mon, 03 Mar 2014 18:07:48 +0100 [thread overview]
Message-ID: <5314B6E4.7030607@alum.mit.edu> (raw)
In-Reply-To: <87a9d7kztm.fsf@fencepost.gnu.org>
On 03/03/2014 05:32 PM, David Kastrup wrote:
> [...]
> So perhaps all of that should just be
>
> while (*slash == '/')
> slash++;
> if (!*slash)
> return it;
>
I just fixed a little thing that caught my eye. You OWNED it. You are
absolutely right.
Will you prepare a patch or would you like me to do it?
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
next prev parent reply other threads:[~2014-03-03 17:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 16:08 [PATCH] cache_tree_find(): remove redundant check in while condition Michael Haggerty
2014-03-03 16:32 ` David Kastrup
2014-03-03 17:07 ` Michael Haggerty [this message]
2014-03-03 17:25 ` David Kastrup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5314B6E4.7030607@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=dak@gnu.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).