From: Fabian Ruch <bafain@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] add: Use struct argv_array in run_add_interactive()
Date: Sat, 15 Mar 2014 13:41:57 +0100 [thread overview]
Message-ID: <53244A95.8050308@gmail.com> (raw)
In-Reply-To: <53243620.8080401@gmail.com>
On 03/15/2014 12:14 PM, Fabian Ruch wrote:
> run_add_interactive() in builtin/add.c manually computes array bounds
> and allocates a static args array to build the add--interactive command
> line, which is error-prone. Use the argv-array helper functions instead.
>
> Signed-off-by: Fabian Ruch <bafain@gmail.com>
> ---
> builtin/add.c | 21 ++++++++++-----------
> 1 file changed, 10 insertions(+), 11 deletions(-)
I should mention that I am applying to this year's edition of Google's
Summer of Code.
next prev parent reply other threads:[~2014-03-15 12:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-15 11:14 [PATCH] add: Use struct argv_array in run_add_interactive() Fabian Ruch
2014-03-15 12:41 ` Fabian Ruch [this message]
2014-03-16 11:42 ` Thomas Rast
2014-03-17 9:28 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53244A95.8050308@gmail.com \
--to=bafain@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).