git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Torsten Bögershausen" <tboegi@web.de>
To: Brian Gesiak <modocache@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-rebase: Teach rebase "-" shorthand.
Date: Tue, 18 Mar 2014 20:26:32 +0100	[thread overview]
Message-ID: <53289DE8.2070104@web.de> (raw)
In-Reply-To: <1395132268-69488-1-git-send-email-modocache@gmail.com>

On 03/18/2014 09:44 AM, Brian Gesiak wrote:
> Teach rebase the same shorthand as checkout and merge; that is, that "-"
> means "the branch we were previously on".
>
> Reported-by: Tim Chase <git@tim.thechases.com>
> Signed-off-by: Brian Gesiak <modocache@gmail.com>
> ---
>   git-rebase.sh     | 4 ++++
>   t/t3400-rebase.sh | 6 ++++++
>   2 files changed, 10 insertions(+)
>
> diff --git a/git-rebase.sh b/git-rebase.sh
> index 5f6732b..2c75e9f 100755
> --- a/git-rebase.sh
> +++ b/git-rebase.sh
> @@ -453,6 +453,10 @@ then
>   		test "$fork_point" = auto && fork_point=t
>   		;;
>   	*)	upstream_name="$1"
> +		if test "$upstream_name" = "-"
> +		then
> +			upstream_name="@{-1}"
> +		fi
>   		shift
>   		;;
>   	esac
> diff --git a/t/t3400-rebase.sh b/t/t3400-rebase.sh
> index 6d94b1f..00aba9f 100755
> --- a/t/t3400-rebase.sh
> +++ b/t/t3400-rebase.sh
> @@ -88,6 +88,12 @@ test_expect_success 'rebase from ambiguous branch name' '
>   	git rebase master
>   '
>
> +test_expect_success 'rebase using shorthand' '
> +	git checkout master
we schould have the "&&"   ^^
> +	git checkout -b shorthand HEAD^
               we schould have the "&&"  ^^
> +	GIT_TRACE=1 git rebase -
And why the GIT_TRACE ?
> +'
> +
>   test_expect_success 'rebase a single mode change' '
>   	git checkout master &&
>   	git branch -D topic &&
>

  reply	other threads:[~2014-03-18 19:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-18  8:44 [PATCH] git-rebase: Teach rebase "-" shorthand Brian Gesiak
2014-03-18 19:26 ` Torsten Bögershausen [this message]
2014-03-18 19:42 ` Junio C Hamano
2014-03-19 11:02   ` [PATCH v2] " Brian Gesiak
2014-03-19 17:53     ` Junio C Hamano
2014-03-19 18:02       ` John Keeping
2014-03-19 18:09         ` Brian Gesiak
2014-03-19 19:02         ` Junio C Hamano
2014-03-19 19:12           ` John Keeping
2014-03-19 19:41             ` Junio C Hamano
2014-03-19 19:55               ` John Keeping
2014-03-19 21:02                 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53289DE8.2070104@web.de \
    --to=tboegi@web.de \
    --cc=git@vger.kernel.org \
    --cc=modocache@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).