From: Michael Haggerty <mhagger@alum.mit.edu>
To: Tanay Abhra <tanayabh@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com, max@quendi.de
Subject: Re: [PATCH v5] commit.c: use skip_prefix() instead of starts_with()
Date: Fri, 21 Mar 2014 16:53:36 +0100 [thread overview]
Message-ID: <532C6080.9010503@alum.mit.edu> (raw)
In-Reply-To: <532C5F47.3020801@alum.mit.edu>
On 03/21/2014 04:48 PM, Michael Haggerty wrote:
> On 03/04/2014 11:07 PM, Tanay Abhra wrote:
>> [...]
>> + found = skip_prefix(buf, sigcheck_gpg_status[i].check + 1);
>> + if(!found) {
>
> Nit: There should be a space between "if" and the opening parenthesis.
Oops, I see I am too late. Junio must have fixed this when queuing the
patch.
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
prev parent reply other threads:[~2014-03-21 15:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 22:07 [PATCH v5] commit.c: use skip_prefix() instead of starts_with() Tanay Abhra
2014-03-21 15:48 ` Michael Haggerty
2014-03-21 15:53 ` Michael Haggerty [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532C6080.9010503@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=max@quendi.de \
--cc=tanayabh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).