From: "Torsten Bögershausen" <tboegi@web.de>
To: "Junio C Hamano" <gitster@pobox.com>,
"Torsten Bögershausen" <tboegi@web.de>,
"Max Horn" <max@quendi.de>
Cc: git@vger.kernel.org, Antoine Pelisse <apelisse@gmail.com>
Subject: Re: [PATCH v3] remote-hg: do not fail on invalid bookmarks
Date: Sat, 22 Mar 2014 17:41:37 +0100 [thread overview]
Message-ID: <532DBD41.6080008@web.de> (raw)
In-Reply-To: <xmqq7g7nrxmv.fsf@gitster.dls.corp.google.com>
On 2014-03-21 23.32, Junio C Hamano wrote:
> Max Horn <max@quendi.de> writes:
>
>> Hi Torsten,
>>
>> On 21.03.2014, at 21:47, Torsten Bögershausen <tboegi@web.de> wrote:
>>
>>> On 2014-03-21 12.36, Max Horn wrote:
>>> All tests passed :-),
>>
>> Excellent.
>>
>>> thanks from my side.
>>> comments inline, some are debatable
>>
>> Thanks for having a close look and for the constructive feedback!
>> Unfortunately, I won't have time to look into this for the next 7 days
>> or so. I wouldn't mind if the patch gets queued with the changes you
>> suggest; but of course that might be a tad too much to ask for, so I'll
>> also be happy to do a "proper" re-roll, but then it has to wait a bit.
>
> In the meantime, I'll pile this on top as "SQUASH???".
Test OK under Linux and Mac,
(so this is a little ACK).
prev parent reply other threads:[~2014-03-22 16:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 11:36 [PATCH v3] remote-hg: do not fail on invalid bookmarks Max Horn
2014-03-21 20:47 ` Torsten Bögershausen
2014-03-21 21:44 ` Max Horn
2014-03-21 22:32 ` Junio C Hamano
2014-03-22 16:41 ` Torsten Bögershausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532DBD41.6080008@web.de \
--to=tboegi@web.de \
--cc=apelisse@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=max@quendi.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).