From: "René Scharfe" <l.s.r@web.de>
To: Andreas Schwab <schwab@linux-m68k.org>,
Marat Radchenko <marat@slonopotamus.org>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v3] MSVC: fix t0040-parse-options crash
Date: Sat, 29 Mar 2014 23:17:11 +0100 [thread overview]
Message-ID: <53374667.3080605@web.de> (raw)
In-Reply-To: <87ha6gpu2t.fsf@igel.home>
Am 29.03.2014 22:34, schrieb Andreas Schwab:
> Marat Radchenko <marat@slonopotamus.org> writes:
>
>> diff --git a/test-parse-options.c b/test-parse-options.c
>> index 434e8b8..6f6c656 100644
>> --- a/test-parse-options.c
>> +++ b/test-parse-options.c
>> @@ -60,7 +60,7 @@ int main(int argc, char **argv)
>> OPT_STRING('o', NULL, &string, "str", "get another string"),
>> OPT_NOOP_NOARG(0, "obsolete"),
>> OPT_SET_PTR(0, "default-string", &string,
>> - "set string to default", (unsigned long)"default"),
>> + "set string to default", (intptr_t)"default"),
>
> Why doesn't OPT_SET_PTR take a pointer?
Good question. Here's another: OPT_SET_PTR (and OPTION_SET_PTR) has
only ever been used by test-parse-options; can we remove it?
René
next prev parent reply other threads:[~2014-03-29 22:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 12:04 [PATCH] MSVC: fix t0040-parse-options Marat Radchenko
2014-03-28 18:19 ` Junio C Hamano
2014-03-29 19:59 ` [PATCH v2] MSVC: fix t0040-parse-options crash Marat Radchenko
2014-03-29 20:09 ` [PATCH v3] " Marat Radchenko
2014-03-29 21:34 ` Andreas Schwab
2014-03-29 22:17 ` René Scharfe [this message]
2014-03-30 2:01 ` Junio C Hamano
2014-03-30 8:29 ` Andreas Schwab
2014-03-31 21:09 ` Jeff King
2014-03-30 11:08 ` [PATCH v4 0/3] Take four on fixing OPT_SET_PTR issues Marat Radchenko
2014-03-31 17:23 ` Junio C Hamano
2014-03-31 21:07 ` Jeff King
2014-03-31 22:54 ` Junio C Hamano
2014-03-30 11:08 ` [PATCH v4 1/3] MSVC: fix t0040-parse-options crash Marat Radchenko
2014-03-30 11:08 ` [PATCH v4 2/3] parse-options: add cast to correct pointer type to OPT_SET_PTR Marat Radchenko
2014-03-31 17:16 ` Junio C Hamano
2014-03-30 11:08 ` [PATCH v4 3/3] parse-options: remove unused OPT_SET_PTR Marat Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53374667.3080605@web.de \
--to=l.s.r@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=marat@slonopotamus.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).