From: Brad King <brad.king@kitware.com>
To: Michael Haggerty <mhagger@alum.mit.edu>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Aman Gupta <aman@tmm1.net>
Subject: Re: [PATCH] update-ref: fail create operation over stdin if ref already exists
Date: Wed, 02 Apr 2014 08:57:15 -0400 [thread overview]
Message-ID: <533C092B.1050801@kitware.com> (raw)
In-Reply-To: <1396426194-3292-1-git-send-email-mhagger@alum.mit.edu>
On 04/02/2014 04:09 AM, Michael Haggerty wrote:
> From: Aman Gupta <aman@tmm1.net>
[snip]
> @@ -147,6 +147,7 @@ static void parse_cmd_create(const char *next)
> struct ref_update *update;
>
> update = update_alloc();
> + update->have_old = 1;
Looks good.
> +test_expect_success 'stdin -z create ref fails when ref exists' '
Strictly speaking we should have a non-z mode test too.
Thanks,
-Brad
next prev parent reply other threads:[~2014-04-03 9:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 8:09 [PATCH] update-ref: fail create operation over stdin if ref already exists Michael Haggerty
2014-04-02 12:57 ` Brad King [this message]
2014-04-03 13:20 ` Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533C092B.1050801@kitware.com \
--to=brad.king@kitware.com \
--cc=aman@tmm1.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).