From: Michael Haggerty <mhagger@alum.mit.edu>
To: Brad King <brad.king@kitware.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Aman Gupta <aman@tmm1.net>
Subject: Re: [PATCH] update-ref: fail create operation over stdin if ref already exists
Date: Thu, 03 Apr 2014 15:20:30 +0200 [thread overview]
Message-ID: <533D601E.8020301@alum.mit.edu> (raw)
In-Reply-To: <533C092B.1050801@kitware.com>
On 04/02/2014 02:57 PM, Brad King wrote:
> On 04/02/2014 04:09 AM, Michael Haggerty wrote:
>> From: Aman Gupta <aman@tmm1.net>
> [snip]
>> @@ -147,6 +147,7 @@ static void parse_cmd_create(const char *next)
>> struct ref_update *update;
>>
>> update = update_alloc();
>> + update->have_old = 1;
>
> Looks good.
>
>> +test_expect_success 'stdin -z create ref fails when ref exists' '
>
> Strictly speaking we should have a non-z mode test too.
This code path is used regardless of whether -z is used, so I don't
think it is necessary to duplicate the test.
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
prev parent reply other threads:[~2014-04-03 13:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 8:09 [PATCH] update-ref: fail create operation over stdin if ref already exists Michael Haggerty
2014-04-02 12:57 ` Brad King
2014-04-03 13:20 ` Michael Haggerty [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533D601E.8020301@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=aman@tmm1.net \
--cc=brad.king@kitware.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).