From: Felipe Contreras <felipe.contreras@gmail.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>,
Felipe Contreras <felipe.contreras@gmail.com>
Cc: Git List <git@vger.kernel.org>,
Matthieu Moy <matthieu.moy@imag.fr>, Jeff King <peff@peff.net>,
John Szakmeister <john@szakmeister.net>
Subject: Re: [PATCH v2 8/9] sha1_name: simplify track finding
Date: Thu, 10 Apr 2014 17:27:07 -0500 [thread overview]
Message-ID: <53471abb6fa76_d696b12f0b0@nysa.notmuch> (raw)
In-Reply-To: <CALkWK0kRAYpZxDkZ6nVPcfo4pqJuTLNFekpQ+tLPPRFJZKUMuw@mail.gmail.com>
Ramkumar Ramachandra wrote:
> Felipe Contreras wrote:
> > It's more efficient to check for the braces first.
>
> Why is it more efficient? So you can error out quickly in the case of
> a malformed string?
That's one reason. The other is that get_sha1_basic() calls upstream_mark()
when we _already_ know there's a @{foo}.
--
Felipe Contreras
next prev parent reply other threads:[~2014-04-10 22:37 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 19:04 [PATCH v2 0/9] Introduce publish tracking branch Felipe Contreras
2014-04-10 19:04 ` [PATCH v2 1/9] push: trivial reorganization Felipe Contreras
2014-04-10 19:04 ` [PATCH v2 2/9] Add concept of 'publish' branch Felipe Contreras
2014-04-10 19:04 ` [PATCH v2 3/9] branch: allow configuring the publish branch Felipe Contreras
2014-04-10 19:04 ` [PATCH v2 4/9] t: branch add publish branch tests Felipe Contreras
2014-04-10 19:04 ` [PATCH v2 5/9] push: add --set-publish option Felipe Contreras
2014-04-10 19:04 ` [PATCH v2 6/9] branch: display publish branch Felipe Contreras
2014-04-10 22:03 ` Ramkumar Ramachandra
2014-04-10 22:36 ` Felipe Contreras
2014-04-11 11:17 ` Jeff King
2014-04-11 13:48 ` Felipe Contreras
2014-04-12 11:23 ` Jeff King
2014-04-12 14:34 ` Felipe Contreras
2014-04-11 19:24 ` Junio C Hamano
2014-04-11 19:50 ` Felipe Contreras
2014-04-12 11:42 ` Jeff King
2014-04-12 15:05 ` Felipe Contreras
2014-04-15 5:43 ` Jeff King
2014-04-18 23:29 ` Felipe Contreras
2014-04-10 19:04 ` [PATCH v2 7/9] sha1_name: cleanup interpret_branch_name() Felipe Contreras
2014-04-10 21:45 ` Ramkumar Ramachandra
2014-04-10 19:04 ` [PATCH v2 8/9] sha1_name: simplify track finding Felipe Contreras
2014-04-10 21:44 ` Ramkumar Ramachandra
2014-04-10 22:27 ` Felipe Contreras [this message]
2014-04-10 19:04 ` [PATCH v2 9/9] sha1_name: add support for @{publish} marks Felipe Contreras
2014-04-10 21:40 ` Ramkumar Ramachandra
2014-04-10 22:25 ` Felipe Contreras
2014-04-10 21:49 ` Ramkumar Ramachandra
2014-04-10 22:28 ` Felipe Contreras
2014-04-10 21:21 ` [PATCH v2 0/9] Introduce publish tracking branch Junio C Hamano
2014-04-11 9:15 ` Matthieu Moy
2014-04-11 14:25 ` Felipe Contreras
2014-04-11 17:25 ` Matthieu Moy
2014-04-11 19:16 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53471abb6fa76_d696b12f0b0@nysa.notmuch \
--to=felipe.contreras@gmail.com \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=john@szakmeister.net \
--cc=matthieu.moy@imag.fr \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).