From: Felipe Contreras <felipe.contreras@gmail.com>
To: Daniel Liew <delcypher@gmail.com>, git@vger.kernel.org
Cc: felipe.contreras@gmail.com
Subject: RE: [PATCH] git-remote-hg : Enable use of, $GIT_DIR/hg/origin/clone/.hg/hgrc
Date: Sat, 12 Apr 2014 15:01:52 -0500 [thread overview]
Message-ID: <53499bb02c140_285f9032ec58@nysa.notmuch> (raw)
In-Reply-To: <53076DFC.1000602@gmail.com>
Daniel Liew wrote:
> git-remote-hg : Enable use of, $GIT_DIR/hg/origin/clone/.hg/hgrc
>
> Use the hgrc configuration file in the internal mercurial repository in
> addition to the other system wide hgrc files. This is done by using the
> 'ui' object from the 'repository' object which will have loaded the
> repository hgrc file if it exists.
What is the problem you are trying to solve? Is there a way to test that this
code is working correctly?
> Prior to this patch the mercurial repository's hgrc file was ignored
> which I consider to be a bug.
It might be, although the internal repository is not supposed to be used by the
user.
> Signed-off-by: Dan Liew <delcypher@gmail.com>
> ---
> contrib/remote-helpers/git-remote-hg | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/remote-helpers/git-remote-hg
> b/contrib/remote-helpers/git-remote-hg
> index eb89ef6..451842a 100755
> --- a/contrib/remote-helpers/git-remote-hg
> +++ b/contrib/remote-helpers/git-remote-hg
> @@ -421,7 +421,7 @@ def get_repo(url, alias):
>
> repo = hg.repository(myui, local_path)
> try:
> - peer = hg.peer(myui, {}, url)
> + peer = hg.peer(repo._unfilteredrepo.ui, {}, url)
Why not repo.unfiltered.ui? Or just repo.ui.
Cheers.
--
Felipe Contreras
next prev parent reply other threads:[~2014-04-12 20:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 15:17 [PATCH] git-remote-hg : Enable use of, $GIT_DIR/hg/origin/clone/.hg/hgrc Daniel Liew
2014-03-24 15:07 ` Delcypher
2014-04-12 20:01 ` Felipe Contreras [this message]
2014-04-15 15:37 ` Delcypher
2014-04-20 18:12 ` Felipe Contreras
2014-04-20 19:57 ` Delcypher
2014-04-20 19:54 ` Felipe Contreras
2014-04-20 20:36 ` Delcypher
2014-04-20 20:48 ` Felipe Contreras
2014-04-20 21:25 ` Delcypher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53499bb02c140_285f9032ec58@nysa.notmuch \
--to=felipe.contreras@gmail.com \
--cc=delcypher@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).