From: "Torsten Bögershausen" <tboegi@web.de>
To: Jeff King <peff@peff.net>, git@vger.kernel.org, kasal@ucw.cz
Subject: Re: [PATCH] config.c: fix a compiler warning
Date: Wed, 16 Apr 2014 18:38:19 +0200 [thread overview]
Message-ID: <534EB1FB.5040405@web.de> (raw)
In-Reply-To: <20140416152920.GA4691@sigill.intra.peff.net>
On 2014-04-16 17.29, Jeff King wrote:
> On Wed, Apr 16, 2014 at 04:13:53PM +0200, Stepan Kasal wrote:
>
>> Date: Thu, 10 Apr 2014 16:37:15 +0200
>>
>> This change fixes a gcc warning when building msysGit.
[]
> +NORETURN
> static void die_bad_number(const char *name, const char *value)
> {
> const char *reason = errno == ERANGE ?
>
> Does that also silence the warning?
>
> -Peff
This works under gcc 4.2.1 Mac OS: the warning is away.
next prev parent reply other threads:[~2014-04-16 16:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 14:13 [PATCH] config.c: fix a compiler warning Stepan Kasal
2014-04-16 15:29 ` Jeff King
2014-04-16 16:38 ` Torsten Bögershausen [this message]
2014-04-16 16:51 ` [PATCH] config.c: mark die_bad_number as NORETURN Jeff King
2014-04-16 17:21 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534EB1FB.5040405@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=kasal@ucw.cz \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).