From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>,
Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] remote-helpers: move tests out of contrib
Date: Mon, 21 Apr 2014 14:23:14 -0500 [thread overview]
Message-ID: <53557021ed75d_414c80b30836@nysa.notmuch> (raw)
In-Reply-To: <xmqqy4yy8p0l.fsf@gitster.dls.corp.google.com>
Junio C Hamano wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
> >> This step needs a bit more work, I am afraid, to at least have these
> >> three test scripts follow the same numbering scheme. Especially given
> >> that there were recent discussions on allowing a range of tests to
> >> be run (or omitted) via notations like "5000,5020,9800-9812", not
> >> doing so now will make it harder to implement such an enhancement.
> >
> > I don't see how such an enhancement would be beneficial to these remote
> > helpers.
>
> Why are remote helpers more special than other parts of the system?
They aren't.
> Do they _have to_ be different and special?
No.
> > For starters there aren't any number rages left for them,...
>
> Wouldn't "5 - the pull and exporting" be an obvious space for them,
> especiall somewhere after 5800?
Not _that_ obvious. If you are OK with having the hg-hg-git test (a test which
requires hg-git, a tool that is completely independent from git-remote-hg)
there, then fine.
--
Felipe Contreras
next prev parent reply other threads:[~2014-04-21 19:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-20 21:39 [PATCH 0/2] remote-helpers: graduate Felipe Contreras
2014-04-20 21:39 ` [PATCH 1/2] remote-helpers: move out of contrib Felipe Contreras
2014-04-20 21:39 ` [PATCH 2/2] remote-helpers: move tests " Felipe Contreras
2014-04-21 18:36 ` Junio C Hamano
2014-04-21 18:53 ` Felipe Contreras
2014-04-21 19:24 ` Junio C Hamano
2014-04-21 19:23 ` Felipe Contreras [this message]
2014-04-21 18:06 ` [PATCH 0/2] remote-helpers: graduate Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53557021ed75d_414c80b30836@nysa.notmuch \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).