From: Ilya Bobyr <ilya.bobyr@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>,
Stephen Leake <stephen_leake@stephe-leake.org>,
git@vger.kernel.org
Subject: Re: [RTC/PATCH] Add 'update-branch' hook
Date: Tue, 22 Apr 2014 10:09:49 -0700 [thread overview]
Message-ID: <5356A25D.1050001@gmail.com> (raw)
In-Reply-To: <5356996d12ede_3e5aed7308e5@nysa.notmuch>
On 4/22/2014 9:31 AM, Felipe Contreras wrote:
> Stephen Leake wrote:
>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>
>>> Ilya Bobyr wrote:
>>>> On 4/21/2014 2:17 PM, Felipe Contreras wrote:
>>>>> Ilya Bobyr wrote:
>>>>>
>>>>>> Also, most have names that start with either "pre-" or "post-".
>>>>>> It seems reasonable for both "pre-update-branch" and
>>>>>> "post-update-branch" to exist.
>>>>> I don't see what would be the point in that.
>>>> Do you see the point in the other hooks doing that?
>>> Yes, there a reason for the existance of those hooks. Now tell me why would
>>> anybody use post-update-branch instead of pre-update-branch?
>> I have a branch which should always be recompiled on update;
>> post-update-branch would be a good place for that.
> And why would pre-update-branch not serve that purpose?
"pre-" hook could be used, but if the hooks is not supposed to prevent
the operation, it seems reasonable to put it in the "post-" hook should
one be available.
For example, for clone and branch that would mean that that the branch
sections are already created in .git/config, but for "pre-" hooks,
should be find the right spot, configuration could probably be absent
just yet.
I do not think that someone is objecting adding just the "pre-" hook first.
But it seems unlikely that one can envision all the possible use cases
to say that "post-" hook would never be useful.
next prev parent reply other threads:[~2014-04-22 17:10 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 2:23 [RTC/PATCH] Add 'update-branch' hook Felipe Contreras
2014-04-21 7:25 ` Eric Sunshine
2014-04-21 20:02 ` Ilya Bobyr
2014-04-21 20:49 ` Felipe Contreras
2014-04-21 21:15 ` Ilya Bobyr
2014-04-21 21:17 ` Felipe Contreras
2014-04-21 21:39 ` Ilya Bobyr
2014-04-21 21:36 ` Felipe Contreras
2014-04-22 14:43 ` Stephen Leake
2014-04-22 16:31 ` Felipe Contreras
2014-04-22 17:09 ` Ilya Bobyr [this message]
2014-04-22 17:28 ` Felipe Contreras
2014-04-23 7:49 ` Stephen Leake
2014-04-23 9:07 ` Felipe Contreras
2014-04-23 22:44 ` Junio C Hamano
2014-04-24 1:11 ` Felipe Contreras
2014-04-26 17:38 ` Junio C Hamano
2014-04-26 19:28 ` Felipe Contreras
2014-04-24 14:26 ` Stephen Leake
2014-04-24 18:08 ` Felipe Contreras
2014-04-21 21:52 ` Junio C Hamano
2014-04-21 22:26 ` Felipe Contreras
2014-04-21 23:00 ` Junio C Hamano
2014-04-23 21:30 ` Felipe Contreras
2014-04-23 22:15 ` Junio C Hamano
2014-04-24 1:00 ` Felipe Contreras
2014-04-22 6:41 ` Ilya Bobyr
2014-04-22 16:30 ` Felipe Contreras
2014-04-21 21:17 ` Ilya Bobyr
2014-04-21 21:15 ` Felipe Contreras
2014-04-21 21:36 ` Ilya Bobyr
2014-04-21 21:35 ` Felipe Contreras
[not found] ` <CADcHDF+XcWEkvyP3tL4ibicnaMVJpixUZu1Ces0BXWkzPGsodw@mail.gmail.com>
2014-04-21 22:24 ` Felipe Contreras
2014-04-22 6:05 ` Ilya Bobyr
2014-04-22 6:45 ` Felipe Contreras
2014-04-22 7:00 ` Ilya Bobyr
2014-04-22 6:56 ` Felipe Contreras
2014-04-22 6:35 ` Ilya Bobyr
2014-04-22 16:27 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5356A25D.1050001@gmail.com \
--to=ilya.bobyr@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=stephen_leake@stephe-leake.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).