From: Johannes Sixt <j6t@kdbg.org>
To: Marius Ungureanu <marius.ungureanu@xamarin.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] add csharp userdiff tests
Date: Sun, 27 Apr 2014 22:12:44 +0200 [thread overview]
Message-ID: <535D64BC.8060403@kdbg.org> (raw)
In-Reply-To: <CF7066B0-539D-4FAB-8845-8ED60DF1F17E@xamarin.com>
Am 27.04.2014 18:46, schrieb Marius Ungureanu:
> Is it okay though if I add a few tests to show what is broken?
>
> I think this can’t be solved at a regex level.
It's OK to add tests that show breakages even if there is no immediate
solution.
>> You can mark a userdiff test case that demonstrates a breakage by
>> including the work "broken" somewhere in the file. See
>> http://www.repo.or.cz/w/alt-git.git/commitdiff/9cc444f0570b196f1c51664ce2de1d8e1dee6046
You add tests including broken cases first, and then in the follow-up
patch that fixes the broken ones, you also mark the tests as fixed, like
I did in the follow-up patch of the above example:
http://www.repo.or.cz/w/alt-git.git/commitdiff/8a2e8da367f7175465118510b474ad365161d6b1
-- Hannes
next prev parent reply other threads:[~2014-04-27 20:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 23:25 [PATCH] Updated C# userdiff patterns Marius Ungureanu
2014-04-26 7:10 ` Johannes Sixt
2014-04-26 9:55 ` Marius Ungureanu
2014-04-26 10:49 ` Marius Ungureanu
2014-04-26 17:49 ` Johannes Sixt
2014-04-26 18:33 ` Marius Ungureanu
2014-04-26 18:50 ` Johannes Sixt
2014-04-26 18:52 ` Marius Ungureanu
2014-04-27 13:43 ` Marius Ungureanu
2014-04-27 13:45 ` [PATCH 1/2] update " Marius Ungureanu
2014-04-27 13:48 ` [PATCH 2/2] add csharp userdiff tests Marius Ungureanu
2014-04-27 13:47 ` Marius Ungureanu
2014-04-27 16:19 ` Johannes Sixt
2014-04-27 16:46 ` Marius Ungureanu
2014-04-27 20:12 ` Johannes Sixt [this message]
2014-04-27 17:11 ` Marius Ungureanu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535D64BC.8060403@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=marius.ungureanu@xamarin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).