From: Michael Haggerty <mhagger@alum.mit.edu>
To: Christian Couder <chriscool@tuxfamily.org>,
Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Johan Herland <johan@herland.net>,
Josh Triplett <josh@joshtriplett.org>,
Thomas Rast <tr@thomasrast.ch>,
Dan Carpenter <dan.carpenter@oracle.com>,
Greg Kroah-Hartman <greg@kroah.com>, Jeff King <peff@peff.net>,
Eric Sunshine <sunshine@sunshineco.com>,
Ramsay Jones <ramsay@ramsay1.demon.co.uk>,
Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [RFC/PATCH 1/2] trailer: fix to ignore any line starting with '#'
Date: Mon, 28 Apr 2014 07:58:32 +0200 [thread overview]
Message-ID: <535DEE08.9090402@alum.mit.edu> (raw)
In-Reply-To: <20140427201238.16880.13774.chriscool@tuxfamily.org>
On 04/27/2014 10:12 PM, Christian Couder wrote:
> It looks like the commit-msg hook is passed a commit
> message that can contain lines starting with a '#'.
> Those comment lines will be removed from the commit
> message after the hook is run.
>
> If we want "git interpret-trailers" to be able to
> process commit messages correctly in the commit-msg
> hook we need to ignore those lines.
Shouldn't this take into account the config setting core.commentchar?
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
next prev parent reply other threads:[~2014-04-28 5:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-27 20:12 [RFC/PATCH 0/2] fix and examples for git interpret-trailers Christian Couder
2014-04-27 20:12 ` [RFC/PATCH 1/2] trailer: fix to ignore any line starting with '#' Christian Couder
2014-04-28 5:58 ` Michael Haggerty [this message]
2014-04-28 8:16 ` Christian Couder
2014-04-27 20:12 ` [RFC/PATCH 2/2] trailer: add examples to the documentation Christian Couder
2014-04-28 22:12 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535DEE08.9090402@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=chriscool@tuxfamily.org \
--cc=dan.carpenter@oracle.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=greg@kroah.com \
--cc=johan@herland.net \
--cc=josh@joshtriplett.org \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=ramsay@ramsay1.demon.co.uk \
--cc=sunshine@sunshineco.com \
--cc=tr@thomasrast.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).