From: Felipe Contreras <felipe.contreras@gmail.com>
To: Mark Lodato <lodato@google.com>, git@vger.kernel.org
Cc: Mark Lodato <lodato@google.com>,
Felipe Contreras <felipe.contreras@gmail.com>
Subject: RE: [PATCH] git-completion.zsh: do not clobber complete()
Date: Wed, 30 Apr 2014 00:58:53 -0500 [thread overview]
Message-ID: <5360911d8fb6e_597a125b30828@nysa.notmuch> (raw)
In-Reply-To: <1392413040-28436-1-git-send-email-lodato@google.com>
Mark Lodato wrote:
> Previously, git-completion.zsh redefined complete() to make
> __git_complete() a no-op. This broke zsh's built-in bash completion
> compatibility layer (bashcompinit), which defines its own complete().
How exactly? I'm testing this and I don't see any problems. I run
'type -f _complete' and I get bashcompinit's complete, and the internal
_complete() function is used only by the _git completion.
How have you configured this completion? Are you using the recommended
instructions?
--
Felipe Contreras
next prev parent reply other threads:[~2014-04-30 6:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 21:24 [PATCH] git-completion.zsh: do not clobber complete() Mark Lodato
2014-04-30 5:58 ` Felipe Contreras [this message]
2014-04-30 10:02 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5360911d8fb6e_597a125b30828@nysa.notmuch \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=lodato@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).