From: Felipe Contreras <felipe.contreras@gmail.com>
To: Phil Pennock <pdp@spodhuis.org>, git@vger.kernel.org
Cc: Felipe Contreras <felipe.contreras@gmail.com>
Subject: RE: [PATCH] zsh completion: 5.0.3 compat, use emulate
Date: Wed, 30 Apr 2014 01:03:53 -0500 [thread overview]
Message-ID: <53609249b388d_597a125b3084d@nysa.notmuch> (raw)
In-Reply-To: <EMXW5CZ-001FUQ-3S@ilmenite.field.spodhuis.org>
Phil Pennock wrote:
> The bash completion pulled into zsh was being pulled in _as_ zsh, but
> used patterns which relied on falling through as unhandled. In zsh
> 5.0.3 this no longer works, resulting in:
>
> __git_complete_remote_or_refspec:33: bad pattern: +*
>
> Fix by telling zsh to emulate sh while sourcing the bash config file,
> which stickily preserves compatibility options in the function context.
> This usage of "emulate" came in with zsh 4.3.10, released 2009-06-01.
I'm using 5.9.5 and I don't see any issue. Howe exactly have you
configured this script?
> Signed-off-by: Phil Pennock <pdp@spodhuis.org>
> ---
> nb: I am not on the git mailing-list, please keep me CC'd.
No need to say that. This is a sane mailing list with doesn't do
reply-to munging[1], so you are Cc'ed by default, in essentially al
MUA's out there.
[1] http://felipec.wordpress.com/2010/08/03/avoid-reply-to-munging-mail-as-mail-was-meant-to-be/
--
Felipe Contreras
next prev parent reply other threads:[~2014-04-30 6:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 8:32 [PATCH] zsh completion: 5.0.3 compat, use emulate Phil Pennock
2014-04-30 6:03 ` Felipe Contreras [this message]
2014-04-30 10:00 ` Felipe Contreras
2014-04-30 19:44 ` Phil Pennock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53609249b388d_597a125b3084d@nysa.notmuch \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=pdp@spodhuis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).