From: Karsten Blees <karsten.blees@gmail.com>
To: Marat Radchenko <marat@slonopotamus.org>,
GIT Mailing-list <git@vger.kernel.org>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
Erik Faye-Lund <kusmabite@gmail.com>
Subject: Re: [PATCH 08/12] MINGW: fix main() signature in http-fetch.c and remote-curl.c
Date: Wed, 30 Apr 2014 10:35:56 +0200 [thread overview]
Message-ID: <5360B5EC.1070907@gmail.com> (raw)
In-Reply-To: <1398762726-22825-9-git-send-email-marat@slonopotamus.org>
Am 29.04.2014 11:12, schrieb Marat Radchenko:
> On MinGW, compat/mingw.h defines a 'mingw_main' wrapper function.
> Fix `warning: passing argument 2 of 'mingw_main' from incompatible
> pointer type` in http-fetch.c and remote-curl.c by dropping 'const'.
>
Would you mind cross checking your changes with the msysgit fork? Fixing the same thing in a slightly different manner will just cause unnecessary conflicts (i.e. unnecessary work for the Git for Windows maintainers, as well as for you to come up with an alternate solution for something that's long been fixed).
See https://github.com/msysgit/git/commit/9206e7fd (squashed from https://github.com/msysgit/git/commit/0115ef83 and https://github.com/msysgit/git/commit/6949537a).
next prev parent reply other threads:[~2014-04-30 8:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 9:11 [PATCH v2] MinGW(-W64) cross-compilation Marat Radchenko
2014-04-29 9:11 ` [PATCH 01/12] MINGW: compat/mingw.h: do not attempt to redefine lseek on mingw-w64 Marat Radchenko
2014-04-29 9:11 ` [PATCH 02/12] MSVC: config.mak.uname: drop -D__USE_MINGW_ACCESS from CFLAGS Marat Radchenko
2014-04-29 9:11 ` [PATCH 03/12] MINGW: compat/mingw.h: drop fork() definition Marat Radchenko
2014-04-29 9:11 ` [PATCH 04/12] MINGW: do not fail at redefining pid_t on MinGW-W64 Marat Radchenko
2014-04-29 9:11 ` [PATCH 05/12] MINGW: config.mak.uname: allow using cURL for non-msysGit builds Marat Radchenko
2014-04-29 9:12 ` [PATCH 06/12] MINGW: git-compat-util.h: use inttypes.h for printf macros Marat Radchenko
2014-04-29 9:12 ` [PATCH 07/12] MINGW: config.mak.uname: reorganize MINGW settings Marat Radchenko
2014-04-29 9:12 ` [PATCH 08/12] MINGW: fix main() signature in http-fetch.c and remote-curl.c Marat Radchenko
2014-04-30 8:35 ` Karsten Blees [this message]
2014-04-30 8:56 ` Erik Faye-Lund
2014-04-30 12:31 ` Johannes Schindelin
2014-04-30 16:38 ` Felipe Contreras
2014-04-30 22:17 ` Stepan Kasal
2014-04-30 22:28 ` [PATCH] Win32: move main macro to a function Stepan Kasal
2014-05-03 7:43 ` [PATCH 08/12] MINGW: fix main() signature in http-fetch.c and remote-curl.c Marat Radchenko
2014-04-29 9:12 ` [PATCH 09/12] Makefile: introduce CROSS_COMPILE variable Marat Radchenko
2014-04-29 9:12 ` [PATCH 10/12] MINGW: compat/poll/poll.c: undef NOGDI Marat Radchenko
2014-04-30 11:41 ` Stepan Kasal
2014-05-03 7:00 ` Marat Radchenko
2014-05-04 18:52 ` Stepan Kasal
2014-05-04 20:55 ` Marat Radchenko
2014-05-04 21:46 ` '502304919' via msysGit
2014-05-05 7:35 ` Stepan Kasal
2014-05-05 7:32 ` Felipe Contreras
2014-05-05 12:15 ` [msysGit] " Stepan Kasal
2014-05-04 20:14 ` Felipe Contreras
2014-04-29 9:12 ` [PATCH 11/12] compat/nedmalloc/malloc.c.h: fix compilation under MinGW-W64 Marat Radchenko
2014-04-29 9:12 ` [PATCH 12/12] MINGW: config.mak.uname: add explicit way to request MinGW-build Marat Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5360B5EC.1070907@gmail.com \
--to=karsten.blees@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
--cc=marat@slonopotamus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).