From: Sebastian Schuberth <sschuberth@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, Stepan Kasal <kasal@ucw.cz>
Cc: GIT Mailing-list <git@vger.kernel.org>,
Erik Faye-Lund <kusmabite@gmail.com>,
Johannes Sixt <j6t@kdbg.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Marat Radchenko <marat@slonopotamus.org>
Subject: Re: [PATCH] MSVC: link dynamically to the CRT
Date: Wed, 30 Apr 2014 21:37:12 +0200 [thread overview]
Message-ID: <536150E8.20809@gmail.com> (raw)
In-Reply-To: <xmqqa9b2fyve.fsf@gitster.dls.corp.google.com>
On 30.04.2014 20:36, Junio C Hamano wrote:
> I am not intimate with the msysgit developer community, and I do not
> know if it is appropriate for me to respond with a
>
> Does this look OK with msysgit folks?
This patch has been carried in the msysgit tree since more than 3 years,
although strictly speaking it does not affect the msysgit build but only
the MSVC build. Stefan is just bringing Karsten's patch upstream with
this patch.
So yes, this is fine.
> cc'ed to the usual suspects (Erik Faye-Lund, Dscho and J6t). Just
> like I do not have to ask "does this look ok?" question when seeing
> a patch from Erik or J6t, is it unnecessary for me to do so for a
> patch from you?
I'm putting Marat in CC who has been recently active in building Git
with MSVC.
--
Sebastian Schuberth
next prev parent reply other threads:[~2014-04-30 19:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 10:25 [PATCH] MSVC: link dynamically to the CRT Stepan Kasal
2014-04-30 18:36 ` Junio C Hamano
2014-04-30 19:37 ` Sebastian Schuberth [this message]
2014-04-30 19:54 ` Junio C Hamano
2014-05-03 6:30 ` Marat Radchenko
2014-04-30 20:17 ` Stepan Kasal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536150E8.20809@gmail.com \
--to=sschuberth@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=kasal@ucw.cz \
--cc=kusmabite@gmail.com \
--cc=marat@slonopotamus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).