From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ronnie Sahlberg <sahlberg@google.com>, git@vger.kernel.org
Subject: Re: [PATCH 0/3] Use ref transactions for fetch
Date: Tue, 06 May 2014 22:53:08 +0200 [thread overview]
Message-ID: <53694BB4.2030904@alum.mit.edu> (raw)
In-Reply-To: <xmqq61lig38j.fsf@gitster.dls.corp.google.com>
On 05/06/2014 08:40 PM, Junio C Hamano wrote:
> Michael Haggerty <mhagger@alum.mit.edu> writes:
>
>> It would be pretty annoying to spend a lot of time fetching a big pack,
>> only to have the fetch fail because one reference out of many couldn't
>> be updated. This would force the user to download the entire pack
>> again,...
>
> Is that really true? Doesn't quickfetch optimization kick in for
> the second fetch?
Yes, I guess it would. I wasn't aware of that optimization. Thanks for
the pointer.
I withdraw my objection to using atomic reference updates for fetch.
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
prev parent reply other threads:[~2014-05-06 20:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 18:45 [PATCH 0/3] Use ref transactions for fetch Ronnie Sahlberg
2014-04-22 18:45 ` [PATCH 1/3] fetch.c: clear errno before calling functions that might set it Ronnie Sahlberg
2014-04-23 20:12 ` Eric Sunshine
2014-04-24 15:21 ` Ronnie Sahlberg
2014-04-22 18:45 ` [PATCH 2/3] fetch.c: change s_update_ref to use a ref transaction Ronnie Sahlberg
2014-04-23 20:12 ` Eric Sunshine
2014-04-24 15:22 ` Ronnie Sahlberg
2014-04-22 18:45 ` [PATCH 3/3] fetch.c: use a single ref transaction for all ref updates Ronnie Sahlberg
2014-04-23 20:17 ` Eric Sunshine
2014-04-24 15:23 ` Ronnie Sahlberg
2014-05-05 11:22 ` [PATCH 0/3] Use ref transactions for fetch Michael Haggerty
2014-05-05 15:08 ` Ronnie Sahlberg
2014-05-06 18:40 ` Junio C Hamano
2014-05-06 20:53 ` Michael Haggerty [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53694BB4.2030904@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sahlberg@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).