From: Michael Haggerty <mhagger@alum.mit.edu>
To: Jonathan Nieder <jrnieder@gmail.com>, William Giokas <1007380@gmail.com>
Cc: git@vger.kernel.org, Pete Wyckoff <pw@padd.com>
Subject: Re: Conforming to pep8
Date: Fri, 09 May 2014 16:33:47 +0200 [thread overview]
Message-ID: <536CE74B.8050302@alum.mit.edu> (raw)
In-Reply-To: <20140509020908.GG9218@google.com>
On 05/09/2014 04:09 AM, Jonathan Nieder wrote:
> (cc-ing Pete Wyckoff who maintains git-p4 and Michael Haggerty
> who maintains git-multimail)
> William Giokas wrote:
>
>> - We follow PEP-8 (http://www.python.org/dev/peps/pep-0008/).
>>
>> It's even the first thing that you see when you go looking for 'python'
>> in the coding style document. I just ran every file in the tree that
>> either ended in '.py' or had a python #!, and was greeted with a whole
>> bunch of output::
>>
>> ./git-p4.py
>> ./contrib/svn-fe/svnrdump_sim.py
>> ./contrib/remote-helpers/git-remote-bzr
>> ./contrib/hooks/multimail/post-receive
>> ./contrib/hooks/multimail/migrate-mailhook-config
>> ./contrib/hooks/multimail/git_multimail.py
>> ./contrib/hooks/multimail/README
>> ./contrib/hg-to-git/hg-to-git.py
>> ./contrib/gitview/gitview
>> ./contrib/fast-import/import-zips.py
>
> Thanks for running this check. Passing on the result to the
> maintainers of some of those scripts in case they have thoughts.
>
> [...]
Thanks for the heads-up, William and Jonathan. I wasn't aware of the
pep8 tool. Though I think it enforces a couple of rules that go a bit
beyond PEP8, I don't mind conforming to it, at least with options
--max-line-length=99 --hang-closing
I just committed a change to my upstream repository that gets pep8 to
run cleanly on all Python files.
I don't think it is worth making an extra code drop to Git just to push
these mild stylistic changes, but if somebody disagrees you know where
to find my repo.
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
next prev parent reply other threads:[~2014-05-09 14:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 1:54 Conforming to pep8 William Giokas
2014-05-09 2:09 ` Jonathan Nieder
2014-05-09 14:33 ` Michael Haggerty [this message]
2014-05-09 2:10 ` Felipe Contreras
2014-05-09 3:57 ` William Giokas
2014-05-09 4:36 ` Felipe Contreras
2014-05-09 5:16 ` William Giokas
2014-05-09 7:18 ` Felipe Contreras
2014-05-09 7:28 ` William Giokas
2014-05-09 7:35 ` Felipe Contreras
2014-05-09 7:44 ` William Giokas
2014-05-09 16:01 ` W. Trevor King
2014-05-09 16:14 ` Felipe Contreras
2014-05-09 8:05 ` John Keeping
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536CE74B.8050302@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=1007380@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=pw@padd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).