Re: [PATCH v1 19/25] contrib: remove 'diff-highlight'

[Felipe Contreras <felipe.contreras@gmail.com>]

Jeff King wrote:
> On Thu, May 08, 2014 at 07:58:30PM -0500, Felipe Contreras wrote:
> 
> > No activity since 2012, no tests, no chance of ever graduating.
> 
> I don't think "no activity" is an interesting indicator. This tool _is_
> actively maintained, but it has not needed any fixes since 2012. I use
> it for every single "git log" and "git diff" invocation I do via the
> pager.* config.

If this tool is important to you, I'd say you should write tests so that
we (the rest of the world) can verify that it still works properly.

If it does, it might have a chance of graduating to the core, so it
should stay.

> If we are getting rid of contrib/ I would be happy to continue
> maintaining it out-of-tree. But I honestly cannot tell if this thread is
> serious or passive-aggressive posturing.

It is serious.

The purpose of the 'contrib/' area is not clear. The statemens coming
from Junio don't match what is on 'contrib/README'. So we have a huge
variance of quality all over 'contrib/'. Some tools in contrib have
higher quality than what is part of the core (e.g. they have tests,
while git-archimport doesn't).

So this is a serious attempt at making sure we remain consistent through
the core and contrib/.

Personally I would like to see everything in contrib/ have *at least*
some tests and documentation. Otherwise we know what's going to happen;
they are going to rot and nobody will care that the tools don't work any
more, or they won't even know what they do and how to use them.

-- 
Felipe Contreras