git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: William Giokas <1007380@gmail.com>, git@vger.kernel.org
Subject: RE: Conforming to pep8
Date: Thu, 08 May 2014 21:10:25 -0500	[thread overview]
Message-ID: <536c3911ea173_741a161d310f2@nysa.notmuch> (raw)
In-Reply-To: <20140509015429.GA550@wst420>

William Giokas wrote:
> Which is a whole bunch of errors and warnings thrown by pep8. Is pep8
> just getting put by the wayside? I would much rather have these
> scripts conform to that and have an actual coding style rather than
> just be a hodge-podge of different styles.

Personally I try to follow pep8 in git-remote-{hg,bzr}, but only to some
extent.

I do this:

  [pep8]
  ignore = E401,E302,E201,E202,E203,E126,E128
  max-line-length = 160

That said there's a couple of issues present that I didn't notice.
Thanks for checking.

-- 
Felipe Contreras

  parent reply	other threads:[~2014-05-09  2:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-09  1:54 Conforming to pep8 William Giokas
2014-05-09  2:09 ` Jonathan Nieder
2014-05-09 14:33   ` Michael Haggerty
2014-05-09  2:10 ` Felipe Contreras [this message]
2014-05-09  3:57   ` William Giokas
2014-05-09  4:36     ` Felipe Contreras
2014-05-09  5:16       ` William Giokas
2014-05-09  7:18         ` Felipe Contreras
2014-05-09  7:28           ` William Giokas
2014-05-09  7:35             ` Felipe Contreras
2014-05-09  7:44               ` William Giokas
2014-05-09 16:01                 ` W. Trevor King
2014-05-09 16:14                   ` Felipe Contreras
2014-05-09  8:05 ` John Keeping

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=536c3911ea173_741a161d310f2@nysa.notmuch \
    --to=felipe.contreras@gmail.com \
    --cc=1007380@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).