From: Felipe Contreras <felipe.contreras@gmail.com>
To: William Giokas <1007380@gmail.com>, git@vger.kernel.org
Cc: felipe.contreras@gmail.com
Subject: Re: Conforming to pep8
Date: Fri, 09 May 2014 02:35:34 -0500 [thread overview]
Message-ID: <536c8546ed6fd_182dd0d3100@nysa.notmuch> (raw)
In-Reply-To: <20140509072820.GD9051@wst420>
William Giokas wrote:
> On Fri, May 09, 2014 at 02:18:54AM -0500, Felipe Contreras wrote:
> > William Giokas wrote:
> > > On Thu, May 08, 2014 at 11:36:29PM -0500, Felipe Contreras wrote:
> > > > William Giokas wrote:
> > > > > E401: Multi-line imports seems like something that would just be
> > > > > changing one line
> > > >
> > > > Yes, and make the code very annoying.
> > >
> > > It's 1 extra line in git-remote-hg, and 4 lines in git-remote-bzr.
> >
> > Ah, it refers to the '^import *' not '^from x import'. That's fine then.
>
> Yeah. In fact, for the mercurial stuff the `from mercurial import changegroup`
> line should be on the same line as the other `from mercurial import ...`
> line.
I think the line is too big, it should be rearranged. But every time I
add something to that list I say: I'll clean it up later =/
--
Felipe Contreras
next prev parent reply other threads:[~2014-05-09 7:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 1:54 Conforming to pep8 William Giokas
2014-05-09 2:09 ` Jonathan Nieder
2014-05-09 14:33 ` Michael Haggerty
2014-05-09 2:10 ` Felipe Contreras
2014-05-09 3:57 ` William Giokas
2014-05-09 4:36 ` Felipe Contreras
2014-05-09 5:16 ` William Giokas
2014-05-09 7:18 ` Felipe Contreras
2014-05-09 7:28 ` William Giokas
2014-05-09 7:35 ` Felipe Contreras [this message]
2014-05-09 7:44 ` William Giokas
2014-05-09 16:01 ` W. Trevor King
2014-05-09 16:14 ` Felipe Contreras
2014-05-09 8:05 ` John Keeping
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536c8546ed6fd_182dd0d3100@nysa.notmuch \
--to=felipe.contreras@gmail.com \
--cc=1007380@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).