Re: [PATCH v1 1/2] Remove 'git archimport'

[Felipe Contreras <felipe.contreras@gmail.com>]

Eric Wong wrote:
> Felipe Contreras <felipe.contreras@gmail.com> wrote:
> > Eric Wong wrote:
> > > Felipe Contreras <felipe.contreras@gmail.com> wrote:
> > > > No updates since 2010, and no tests.
> > > 
> > > Who benefits from this removal?  Is this causing a maintenance
> > > burden for Junio?
> > 
> > It is cruft that nobody uses and we are not even testing.
> 
> We do not know nobody uses it.

And we do not know if aybody does either.

As a minimal token that anybody might possibly be using it, I would like
to see it work at least once. Since you said you have arch repos, can
you confirm that it does something?

> I have old GNU Arch projects I have not looked at in a decade.  There
> is a small chance I may use archimport again (whether for nostalgia or
> contractual/legal reasons).

 % git show v1.9.0:git-archimport.perl > ~/bin/git-archimport

Problem solved.

> Of course I know to extract archimport from history, but someone in
> the future may not know the existence of it.

If somebody cared, that person would add tests, or even better, create
an out-of-tree project.

> > > > Plus, foreign SCM tools should live out-of-tree anyway.
> > > 
> > > Even if so, there ought to be a transitionary period in case there are
> > > any users.  We would need to warn potential users of its impending
> > > removal in the documentation and at runtime.
> > 
> > All right, so you are OK with adding deprecation warnings whenever the
> > tool is run, and a note in the documentation?
> 
> No, I am not convinced existing foreign SCM tools should move
> out-of-tree.  Perhaps something like the following would be helpful:

Tell that to Junio.

If tools like git-remote-hg with tests and active maintanance and many
users cannot be in the core, why should 'git archimport' be?

Would you at least be OK with a demotion to contrib/?

-- 
Felipe Contreras