Re: [PATCH v1 04/25] contrib: remove 'buildsystems'

[Felipe Contreras <felipe.contreras@gmail.com>]

Erik Faye-Lund wrote:
> On Fri, May 9, 2014 at 10:14 AM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
> > If you want this script to remain in contrib, please:
> >
> >  a) Write at least a few tests
> >  b) Write some documentation
> >  c) Explain why it cannot live outside the git.git repository like other
> >     tools. [1][2][3]
> 
> (Adding Marius, the original author to the CC-list)
> 
> Uh, why is such a burden required all of a sudden? contrib/README
> mentions no such requirements, and the scripts have been accepted (and
> maintained) since.

contrib/README mentions clearly the expectation that these scripts
eventually move to the core once they mature. This is never going to
happen for these.

It also mentions that inactive ones would be proposed for removal, and
this one is clearly inactive. It has 9 commits (if you count the one
that changes the execution bit).

> Besides, you say "No activity since 2010" - this is not the case,
> bc380fc is from November 2013.

You think changing the execution bit of a file is considered "activity"?

> And there's already *some* documentation in the scripts themselves.

That's nice. So you can just copy that into a README.

> Please stop your pointless crusade that'll only break other people's work-flows.

If you care about these scripts, it should be trivial for you to add at
least a few tests, souldn't it?

Please tell me how exactly will your work-flow be broken. More
specifically, tell me why your scripts cannot be moved outside of git,
like git-extras[1], git-deploy[2], git-ftp[3], and countless other
tools.

Cheers.

[1] https://github.com/visionmedia/git-extras
[2] https://github.com/mislav/git-deploy
[3] https://github.com/git-ftp/git-ftp

-- 
Felipe Contreras