From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>
Cc: Felipe Contreras <felipe.contreras@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] inline constant return from error() function
Date: Sun, 11 May 2014 02:13:01 -0500 [thread overview]
Message-ID: <536f22fd76455_6535d01308cb@nysa.notmuch> (raw)
In-Reply-To: <xmqqppjqczhq.fsf@gitster.dls.corp.google.com>
Junio C Hamano wrote:
> That's kind of W*A*T magic, and I generally try to avoid magic, as
> long as it solves your "can we make both -O2 with new compilers and
> -O3 happy?" I wouldn't complain ;-)
In case anybody is looking for a non-hacky way of doing this that
doesn't depend on the gcc version of the week, this is how I silenced
the warnings in git-fc:
https://github.com/felipec/git/commit/e14ca39ba0092f0305d5fb347e20b829f736b29b
--
Felipe Contreras
next prev parent reply other threads:[~2014-05-11 7:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-04 6:12 [PATCH 0/3] Fix a ton of compiler warnings Felipe Contreras
2014-05-04 6:12 ` [PATCH 1/3] Revert "make error()'s constant return value more visible" Felipe Contreras
2014-05-05 5:49 ` Jeff King
2014-05-05 5:45 ` Felipe Contreras
2014-05-05 6:02 ` Jeff King
2014-05-05 6:14 ` Felipe Contreras
2014-05-05 6:29 ` Jeff King
2014-05-05 7:30 ` Felipe Contreras
2014-05-05 21:29 ` Jeff King
2014-05-06 15:14 ` [PATCH 1/2] inline constant return from error() function Jeff King
2014-05-06 22:29 ` Junio C Hamano
2014-05-07 3:02 ` Jeff King
2014-05-11 17:22 ` Junio C Hamano
2014-05-12 18:13 ` Jeff King
2014-05-11 7:13 ` Felipe Contreras [this message]
2014-05-12 18:44 ` Jonathan Nieder
2014-05-12 18:56 ` Jeff King
2014-05-06 15:17 ` [PATCH 2/2] let clang use the constant-return error() macro Jeff King
2014-05-04 6:12 ` [PATCH 2/3] Revert "silence some -Wuninitialized false positives" Felipe Contreras
2014-05-04 6:12 ` [PATCH 3/3] Silence a bunch of format-zero-length warnings Felipe Contreras
2014-05-04 19:01 ` brian m. carlson
2014-05-04 20:13 ` Felipe Contreras
2014-05-05 5:21 ` Jeff King
2014-05-07 18:19 ` Junio C Hamano
2014-05-07 20:05 ` Heiko Voigt
2014-05-07 20:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536f22fd76455_6535d01308cb@nysa.notmuch \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).