git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>,
	Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] contrib: remote-helpers: add move warnings (v2.0)
Date: Tue, 13 May 2014 17:47:18 -0500	[thread overview]
Message-ID: <5372a0f6650d2_36c411ff3002e@nysa.notmuch> (raw)
In-Reply-To: <xmqq38gdmhdo.fsf@gitster.dls.corp.google.com>

Junio C Hamano wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
> 
> > Sigh, you just don't seem to understand that you are thinking about a
> > different issue. I don't think there's any other way I can explain it to
> > you.
> 
> Perhaps pointing out which commit(s) to revert might be a good point
> to start.

Oh, now you realize it might be nice to avoid this regression I warned
you about.

Why don't you continue schooling me about what constitutes a regression?
I'm such a slow learner.

I was going to do more than pointing to commits, I was going to provide
the fixes with test cases and a detailed explanation. But then you made
your decision.

This patch is what I'm suggesting you to do now. And I'll repeat what I
already told you.

Good luck with your tree.

-- 
Felipe Contreras

  reply	other threads:[~2014-05-13 22:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-13 21:29 [PATCH] contrib: remote-helpers: add move warnings (v2.0) Felipe Contreras
2014-05-13 22:02 ` Junio C Hamano
2014-05-13 22:22   ` Felipe Contreras
2014-05-13 22:41     ` Junio C Hamano
2014-05-13 22:47       ` Felipe Contreras [this message]
2014-05-14  2:16         ` Marius Storm-Olsen
2014-05-14 19:06           ` Junio C Hamano
2014-05-14 19:39             ` Felipe Contreras
2014-05-14 20:21               ` Junio C Hamano
2014-05-14 20:51                 ` Felipe Contreras
2014-05-13 23:11     ` Ronnie Sahlberg
2014-05-13 23:37       ` Felipe Contreras
2014-05-14 16:57         ` Ronnie Sahlberg
2014-05-14 19:26           ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5372a0f6650d2_36c411ff3002e@nysa.notmuch \
    --to=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).