git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] remote-helpers: point at their upstream repositories
Date: Sat, 17 May 2014 00:25:30 -0500	[thread overview]
Message-ID: <5376f2ca5c90d_65b915db2f877@nysa.notmuch> (raw)
In-Reply-To: <20140516225228.GA3988@sigill.intra.peff.net>

Jeff King wrote:

> I agree with the line of reasoning you laid out in your email,
> especially:

What a shock.

> > I would say that the options I see are these three, and I would rank
> > the "warn every time" as less helpful to end-users:
> > 
> >  - rename contrib/remote-helpers to contrib/obsolete-remote-helpers
> >    and add README to point at the upstream.
> > 
> >  - remove contrib/remote-helpers scripts and add README.
> > 
> >  - warn every time the user runs the scripts.
> 
> I hadn't thought of the rename idea, and it would address the concerns I
> brought up. I do think "obsolete" is the wrong word, as it sends the
> wrong message. The helpers are not obsolete; it is our _copy_ of them
> that is.

Originally you said you would respect if I wanted the code out
for v2.0, I said I would like it out at some point, not necessarily in
v2.0. Junio said he was fine with that, but the proposals above don't do
that.

Now it seems you are changing your mind and you are OK with the code
remaining in.

Do what you will, but I already told you what I will do in response.

-- 
Felipe Contreras

  reply	other threads:[~2014-05-17  5:36 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-15 22:56 [PATCH] remote-helpers: point at their upstream repositories Junio C Hamano
2014-05-16  7:37 ` Felipe Contreras
2014-05-16  8:41 ` Jeff King
2014-05-16  8:55   ` Paolo Ciarrocchi
2014-05-16  8:59     ` Jeff King
2014-05-16  9:03     ` Felipe Contreras
2014-05-16  9:23   ` Felipe Contreras
2014-05-16 16:52   ` Junio C Hamano
2014-05-16 22:39     ` Felipe Contreras
2014-05-17  2:11       ` James Denholm
2014-05-17  5:24         ` Felipe Contreras
2014-05-18  1:24           ` James Denholm
2014-05-18  2:31             ` Felipe Contreras
2014-05-18 23:05       ` Junio C Hamano
2014-05-19  1:19         ` Felipe Contreras
2014-05-19 21:31           ` Junio C Hamano
2014-05-20 14:55             ` Michael Haggerty
2014-05-20 15:20               ` Johan Herland
2014-05-20 21:31                 ` Felipe Contreras
2014-05-20 20:52             ` Felipe Contreras
2014-05-16 22:52     ` Jeff King
2014-05-17  5:25       ` Felipe Contreras [this message]
2014-05-17  6:24         ` Jeff King
2014-05-17 17:15           ` Felipe Contreras
2014-05-18 17:34             ` Matthieu Moy
2014-05-18 22:48               ` Felipe Contreras
2014-05-18 23:13           ` Junio C Hamano
2014-05-19  1:31             ` Felipe Contreras
2014-05-19  6:11               ` Junio C Hamano
2014-05-19 21:21                 ` Felipe Contreras
2014-05-19 22:27                   ` Junio C Hamano
2014-05-19 23:17                     ` Junio C Hamano
2014-05-20  2:06                       ` Felipe Contreras
2014-05-20  4:32                         ` Junio C Hamano
2014-05-19 19:01               ` Junio C Hamano
2014-05-20 20:39                 ` Felipe Contreras
2014-05-20 21:11                   ` Junio C Hamano
2014-05-20 21:28                     ` Felipe Contreras
2014-05-20 21:50                       ` Junio C Hamano
2014-05-16 18:07   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5376f2ca5c90d_65b915db2f877@nysa.notmuch \
    --to=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).