From: Marius Storm-Olsen <mstormo@gmail.com>
To: kusmabite@gmail.com, Johannes Sixt <j.sixt@viscovery.net>
Cc: Eric Wong <normalperson@yhbt.net>,
Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>,
msysGit <msysgit@googlegroups.com>
Subject: Re: Re: [PATCH v2] config: preserve config file permissions on edits
Date: Mon, 19 May 2014 10:59:24 -0500 [thread overview]
Message-ID: <537A2A5C.8040706@gmail.com> (raw)
In-Reply-To: <CABPQNSZMExeXXMEUNE9HneK1rfXeLoK=vHZkm38xKt_2VctjXQ@mail.gmail.com>
On 5/19/2014 2:44 AM, Erik Faye-Lund wrote:
> On Mon, May 19, 2014 at 9:13 AM, Johannes Sixt <j.sixt@viscovery.net>
> wrote:
>> I'm not proficient enough to add any ACL fiddling to fchmod that
>> would be required by the above change, whose purpose is to be
>> strict about permissions. Nor am I interested (who the heck is
>> sharing a Windows box anyway? ;-)
>
> Since we use MSVCRT's chmod implementation directly which only
> checks for S_IWRITE,and Get/SetFileAttributes to simply set or clear
> the FILE_ATTRIBUTE_READONLY-flag, perhaps we could do the same
> except using Get/SetFileInformationByHandle instead? That takes us in
> a better direction, IMO. Adding full ACL support seems like a bigger
> project.
>
> If there's no objection, I'll sketch up a patch for that...
IMO, try to stay away from full ACL support, as ACL is slow as hell.
If it's only triggered in edge cases, that's fine, but be sure not to
add any ACL in the main call-paths as it will surely kill performance.
The major speedup which was done by circumventing MSYS/Cygwin standard
posix implementations was bypassing much of the ACL slowness.
--
.marius
--
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
---
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
prev parent reply other threads:[~2014-05-19 15:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 21:58 [PATCH] config: preserve config file permissions on edits Eric Wong
2014-05-06 0:17 ` [PATCH v2] " Eric Wong
2014-05-06 22:02 ` Jeff King
2014-05-19 7:13 ` Johannes Sixt
2014-05-19 7:44 ` Erik Faye-Lund
2014-05-19 9:59 ` Erik Faye-Lund
2014-05-19 19:17 ` Thomas Braun
2014-05-19 19:21 ` Erik Faye-Lund
2014-05-19 15:59 ` Marius Storm-Olsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537A2A5C.8040706@gmail.com \
--to=mstormo@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=kusmabite@gmail.com \
--cc=msysgit@googlegroups.com \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).