git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Torsten Bögershausen" <tboegi@web.de>
To: Elia Pinto <gitter.spiros@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Get rid of the non portable shell export VAR=VALUE costruct
Date: Thu, 22 May 2014 15:13:22 +0200	[thread overview]
Message-ID: <537DF7F2.8000401@web.de> (raw)
In-Reply-To: <1400762896-24324-1-git-send-email-gitter.spiros@gmail.com>

On 2014-05-22 14.48, Elia Pinto wrote:
> Found by check-non-portable-shell.pl

Thanks for picking this up
> -export TEST_DIRECTORY=$(pwd)/../../../t
> +TEST_DIRECTORY=$(pwd)/../../../t && export TEST_DIRECTORY
Minor remark:
Both commands should go on their own line, like this:

TEST_DIRECTORY=$(pwd)/../../../t &&
export TEST_DIRECTORY


And, unrelated to this patch, 
there seem to be a lot of && missing in git-remote-testgit.sh.
But this should be a seperate patch, I think.

  reply	other threads:[~2014-05-22 13:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-22 12:48 [PATCH] Get rid of the non portable shell export VAR=VALUE costruct Elia Pinto
2014-05-22 13:13 ` Torsten Bögershausen [this message]
2014-05-22 13:19   ` David Kastrup
2014-05-22 14:28     ` Johannes Sixt
2014-05-22 14:37       ` David Kastrup
2014-05-22 13:57   ` Elia Pinto
2014-05-22 23:42     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=537DF7F2.8000401@web.de \
    --to=tboegi@web.de \
    --cc=git@vger.kernel.org \
    --cc=gitter.spiros@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).