git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Felipe Contreras" <felipe.contreras@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [ANNOUNCE] git related v0.3
Date: Mon, 19 May 2014 16:27:01 -0500	[thread overview]
Message-ID: <537a7725558c1_afee5d30095@nysa.notmuch> (raw)
In-Reply-To: <CACBZZX6gOeTrLJwL-Zp5hEEbWCipioPgNKt7Tc41ixcQLQshiw@mail.gmail.com>

Ævar Arnfjörð Bjarmason wrote:
> On Mon, May 19, 2014 at 2:36 AM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
> > This tool finds people that might be interested in a patch, by going
> > back through the history for each single hunk modified, and finding
> > people that reviewed, acknowledged, signed, or authored the code the
> > patch is modifying.
> >
> > It does this by running `git blame` incrementally on each hunk, and
> > finding the relevant commit message. After gathering all the relevant
> > people, it groups them to show what exactly was their role when the
> > participated in the development of the relevant commit, and on how many
> > relevant commits they participated. They are only displayed if they pass
> > a minimum threshold of participation.
> >
> > It is similar the the `git contacts` tool in the contrib area, which is a
> > rewrite of this tool, except that `git contacts` does the absolute minimum;
> > `git related` is way superior in every way.
> 
> The general heuristic I use, which I've found to be much better than
> git-blame is:
> 
>  1. Find substrings of code I'm directly removing/altering, and
> functions I'm removing/altering
>  2. Do git log --reverse -p -S'<substr>' (maybe with -- file) for a
> list of substrings

Yes, that is true, but it cannot be automated. When I'm lazy I just do
`git related -cfull a..b`, which will show me the full patches so I can
decide if they are relevant or not.

One possibility would be to add an additional --keywords option to `git
related`. Another would be to add an --interactive where each supposedly
relevant patch is shown for the user to decide if it truly is.

-- 
Felipe Contreras

  reply	other threads:[~2014-05-19 21:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-19  0:36 [ANNOUNCE] git related v0.3 Felipe Contreras
2014-05-19 10:11 ` Ævar Arnfjörð Bjarmason
2014-05-19 21:27   ` Felipe Contreras [this message]
2021-05-27  0:58   ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=537a7725558c1_afee5d30095@nysa.notmuch \
    --to=felipe.contreras@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).