From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Sixt Subject: Re: [PATCH v3 2/5] commit test: Change $PWD to $(pwd) Date: Tue, 27 May 2014 08:34:46 +0200 Message-ID: <53843206.3040902@viscovery.net> References: <20140525062427.GA94219@sirius.att.net> <1401130586-93105-1-git-send-email-caleb@calebthompson.io> <1401130586-93105-3-git-send-email-caleb@calebthompson.io> <538426D3.8090107@viscovery.net> <20140527061448.GA25927@hudson.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: git@vger.kernel.org, Jeff King , =?UTF-8?B?Tmd1eeG7hW4g?= =?UTF-8?B?VGjDoWkgTmfhu41jIER1eQ==?= , Eric Sunshine , Caleb Thompson To: Jeremiah Mahler X-From: git-owner@vger.kernel.org Tue May 27 08:34:56 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WpAyO-0002QZ-9d for gcvg-git-2@plane.gmane.org; Tue, 27 May 2014 08:34:56 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751779AbaE0Gev (ORCPT ); Tue, 27 May 2014 02:34:51 -0400 Received: from so.liwest.at ([212.33.55.23]:36671 "EHLO so.liwest.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751524AbaE0Gev (ORCPT ); Tue, 27 May 2014 02:34:51 -0400 Received: from [81.10.228.254] (helo=theia.linz.viscovery) by so.liwest.at with esmtpa (Exim 4.80.1) (envelope-from ) id 1WpAyF-0005mk-JW; Tue, 27 May 2014 08:34:48 +0200 Received: from [192.168.1.95] (J6T.linz.viscovery [192.168.1.95]) by theia.linz.viscovery (Postfix) with ESMTP id 4C20616613; Tue, 27 May 2014 08:34:47 +0200 (CEST) User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 In-Reply-To: <20140527061448.GA25927@hudson.localdomain> X-Enigmail-Version: 1.6 X-Spam-Score: -1.0 (-) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Please do not cull the Cc list. Am 5/27/2014 8:14, schrieb Jeremiah Mahler: > On Tue, May 27, 2014 at 07:46:59AM +0200, Johannes Sixt wrote: >> Am 5/26/2014 20:56, schrieb Caleb Thompson: >>> Signed-off-by: Caleb Thompson >>> --- >>> t/t7507-commit-verbose.sh | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/t/t7507-commit-verbose.sh b/t/t7507-commit-verbose.sh >>> index 6d778ed..3b06d73 100755 >>> --- a/t/t7507-commit-verbose.sh >>> +++ b/t/t7507-commit-verbose.sh >>> @@ -8,7 +8,7 @@ cat >check-for-diff <>> exec grep '^diff --git' "\$1" >>> EOF >>> chmod +x check-for-diff >>> -test_set_editor "$PWD/check-for-diff" >>> +test_set_editor "$(pwd)/check-for-diff" >>> >>> cat >message <<'EOF' >>> subject >> >> Why? I see no benefit. Both $PWD and $(pwd) work fine everywhere, >> including Windows, and the former is faster, particularly on Windows. > > I don't know the technical details of why this change is needed. > But someone felt it was important enough to put in t/README. > > - When a test checks for an absolute path that a git command generated, > construct the expected value using $(pwd) rather than $PWD, > $TEST_DIRECTORY, or $TRASH_DIRECTORY. It makes a difference on > Windows, where the shell (MSYS bash) mangles absolute path names. > For details, see the commit message of 4114156ae9. That someone was I. I appreciate that people study t/README and do not ignore the sentence. However, it does not apply to the situation because the path to the editor is not "generated by a git command and checked for by a test". That said, it is not wrong to use $(pwd) with test_set_editor, it's just unnecessarily slow. -- Hannes