From: "Jakub Narębski" <jnareb@gmail.com>
To: Pasha Bolokhov <pasha.bolokhov@gmail.com>,
Duy Nguyen <pclouds@gmail.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH v3] Add an explicit GIT_DIR to the list of excludes
Date: Wed, 28 May 2014 20:53:18 +0200 [thread overview]
Message-ID: <5386309E.3070003@gmail.com> (raw)
In-Reply-To: <CAKpPgvfqTBxFXOaStEyyS7wAdR5aUsEOX_M2gPvGz4_dJYvTOA@mail.gmail.com>
W dniu 2014-05-27 19:16, Pasha Bolokhov pisze:
>>> Add GIT_DIR to the list of excludes in setup_standard_excludes(),
>>> while checking that GIT_DIR is not just '.git', in which case it
>>> would be ignored by default, and that GIT_DIR is inside GIT_WORK_TREE
>>>
>> gives git-grep.txt and git-ls-files.txt. I don't know if we need to
>> add something about this extra exclude rule to those .txt. If it's so
>> obvious that this should be the expected behavior, then probably not.
>
> I suggest this. There appears to be a notion of "standard
> excludes" both in the code (dir.c) and in the man pages (git-grep,
> git-ls-files). However, it doesn't actually appear to be defined
> strictly speaking. So my suggestion is to define those "standard
> excludes" in one place (say "gitignore(5)"), and make other man pages
> (git-config, git-grip, git-ls-files) have references to that place
> instead of explaining every time in detail what is being excluded.
Or define those "standard excludes" in standard-excludes.txt "partial",
and include said file from git-grep(1), git-ls-files(1), and perhaps
gitignore(5).
--
Jakub Narębski
next prev parent reply other threads:[~2014-05-28 18:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 17:33 [PATCH v3] Add an explicit GIT_DIR to the list of excludes Pasha Bolokhov
2014-05-23 20:42 ` Junio C Hamano
2014-05-23 22:40 ` Pasha Bolokhov
2014-05-24 1:41 ` Duy Nguyen
2014-05-27 17:16 ` Pasha Bolokhov
2014-05-28 18:53 ` Jakub Narębski [this message]
2014-05-29 2:33 ` Pasha Bolokhov
2014-05-29 10:34 ` Jakub Narębski
2014-05-27 18:04 ` Junio C Hamano
2014-05-27 21:46 ` Pasha Bolokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5386309E.3070003@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=pasha.bolokhov@gmail.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).