From: Tanay Abhra <tanayabh@gmail.com>
To: Philip Oakley <philipoakley@iee.org>
Cc: GitList <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>, "Jeff King" <peff@peff.net>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Robert Clausecker" <fuz@fuz.su>,
"Alex Riesen" <raa.lkml@gmail.com>,
"Matthieu Moy" <Matthieu.Moy@grenoble-inp.fr>
Subject: Re: [PATCH] doc git: multivar configuration parameters append to existing values
Date: Mon, 16 Jun 2014 11:35:11 -0700 [thread overview]
Message-ID: <539F38DF.3090004@gmail.com> (raw)
In-Reply-To: <1402922952-172-1-git-send-email-philipoakley@iee.org>
On 06/16/2014 05:49 AM, Philip Oakley wrote:
> Pass a configuration parameter to the command. The value
> - given will override values from configuration files.
> + given will override single valued variables from configuration
> + files, and append to multivar variables. Previous multivar values
Nit: Forgive me if I am wrong, but `, and` is used for joining two independent
clauses. It would be better to drop the comma.
> + remain in effect. Use "insteadOf" style config variables when an
> + over-ride is needed.
> The <name> is expected in the same format as listed by
> 'git config' (subkeys separated by dots).
>
>
'insteadOf' is a very specific approach for a general suggestion because it is only
used in url.*.insteadof in the whole codebase. Also, it has a variation described in
urls.txt as "pushinsteadof". So, if a problem such as mentioned above arises in
a different scenario 'insteadOf' cannot be used in it.
next prev parent reply other threads:[~2014-06-16 18:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 12:49 [PATCH] doc git: multivar configuration parameters append to existing values Philip Oakley
2014-06-16 18:35 ` Tanay Abhra [this message]
2014-06-16 19:42 ` Philip Oakley
2014-06-16 18:43 ` Junio C Hamano
2014-06-16 19:38 ` Philip Oakley
2014-06-16 21:10 ` Junio C Hamano
2014-06-17 22:03 ` Philip Oakley
2014-06-16 19:48 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539F38DF.3090004@gmail.com \
--to=tanayabh@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=avarab@gmail.com \
--cc=fuz@fuz.su \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=philipoakley@iee.org \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).