From: Karsten Blees <karsten.blees@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>, msysGit <msysgit@googlegroups.com>
Subject: Re: [PATCH v6 05/11] trace: add infrastructure to augment trace output with additional info
Date: Sat, 21 Jun 2014 01:32:13 +0200 [thread overview]
Message-ID: <53A4C47D.609@gmail.com> (raw)
In-Reply-To: <xmqqmwd7citp.fsf@gitster.dls.corp.google.com>
Am 21.06.2014 00:33, schrieb Junio C Hamano:
> Karsten Blees <karsten.blees@gmail.com> writes:
>
>> To be able to add a common prefix or suffix to all trace output (e.g.
>> a timestamp or file:line of the caller), factor out common setup and
>> cleanup tasks of the trace* functions.
>>
>> Some unit-tests use trace output to verify internal state, and variable
>> output such as timestamps and line numbers are not useful there. Disable
>> additional trace output if GIT_TRACE_BARE is set.
>
> Hmph, this makes me wonder if we are better off making these
> additional trace output optional, i.e. not disabling with
> GIT_TRACE_BARE like this, but show the new output only when
> explicitly asked for by setting GIT_TRACE_PERF or something.
>
GIT_TRACE_VERBOSE perhaps? It affects all trace output, not just
GIT_TRACE_PERFORMANCE. The tests would still have to disable it
explicitly, though, in case someone sets it in their profile.
However, IIRC conclusion of v4 discussion was that this would be
useful for all trace output [1], so I think it should be the default.
[1] https://groups.google.com/forum/#!topic/msysgit/UMKTvmZX5aI
--
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
---
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2014-06-20 23:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 21:03 [PATCH v6 00/11] add performance tracing facility Karsten Blees
2014-06-20 21:04 ` [PATCH v6 01/11] trace: move trace declarations from cache.h to new trace.h Karsten Blees
2014-06-20 21:04 ` [PATCH v6 02/11] trace: consistently name the format parameter Karsten Blees
2014-06-20 21:05 ` [PATCH v6 03/11] trace: remove redundant printf format attribute Karsten Blees
2014-06-20 21:05 ` [PATCH v6 04/11] trace: factor out printing to the trace file Karsten Blees
2014-06-20 21:06 ` [PATCH v6 05/11] trace: add infrastructure to augment trace output with additional info Karsten Blees
2014-06-20 22:33 ` Junio C Hamano
2014-06-20 23:32 ` Karsten Blees [this message]
2014-06-21 0:33 ` Junio C Hamano
2014-06-20 21:07 ` [PATCH v6 06/11] trace: add current timestamp to all trace output Karsten Blees
2014-06-20 21:07 ` [PATCH v6 07/11] trace: move code around, in preparation to file:line output Karsten Blees
2014-06-20 21:08 ` [PATCH v6 08/11] trace: add 'file:line' to all trace output Karsten Blees
2014-06-20 21:09 ` [PATCH v6 09/11] trace: add high resolution timer function to debug performance issues Karsten Blees
2014-06-20 21:10 ` [PATCH v6 10/11] trace: add trace_performance facility " Karsten Blees
2014-06-20 21:10 ` [PATCH v6 11/11] git: add performance tracing for git's main() function to debug scripts Karsten Blees
2014-06-20 22:49 ` [PATCH v6 00/11] add performance tracing facility Philip Oakley
2014-06-20 23:42 ` Karsten Blees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A4C47D.609@gmail.com \
--to=karsten.blees@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).