From: "Torsten Bögershausen" <tboegi@web.de>
To: Karsten Blees <karsten.blees@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: trace.c: struct timeval tv not portable
Date: Sun, 29 Jun 2014 08:53:44 +0200 [thread overview]
Message-ID: <53AFB7F8.7070701@web.de> (raw)
The following printout gives a warning:
(trace.c, arounf line 105)
strbuf_addf(buf, "%02d:%02d:%02d.%06ld ", tm.tm_hour, tm.tm_min,
tm.tm_sec, tv.tv_usec);
trace.c:105: warning: format ‘%06ld’ expects type ‘long int’, but argument 6 has type ‘__darwin_suseconds_t’
A format string of "%06ld" for is not always good for tv.tv_usec
http://pubs.opengroup.org/onlinepubs/009695399/basedefs/sys/time.h.html
A better solution would be:
strbuf_addf(buf, "%02d:%02d:%02d.%06ld ", tm.tm_hour, tm.tm_min,
tm.tm_sec, (long int)tv.tv_usec);
reply other threads:[~2014-06-29 6:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AFB7F8.7070701@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=karsten.blees@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).