git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jakub Narębski" <jnareb@gmail.com>
To: Christian Couder <chriscool@tuxfamily.org>,
	Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Johan Herland <johan@herland.net>,
	Josh Triplett <josh@joshtriplett.org>,
	Thomas Rast <tr@thomasrast.ch>,
	Michael Haggerty <mhagger@alum.mit.edu>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Greg Kroah-Hartman <greg@kroah.com>, Jeff King <peff@peff.net>,
	Eric Sunshine <sunshine@sunshineco.com>,
	Ramsay Jones <ramsay@ramsay1.demon.co.uk>,
	Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH v12 11/11] Documentation: add documentation for 'git interpret-trailers'
Date: Mon, 30 Jun 2014 13:57:40 +0200	[thread overview]
Message-ID: <53B150B4.1030303@gmail.com> (raw)
In-Reply-To: <20140525053223.5329.28002.chriscool@tuxfamily.org>

Christian Couder wrote:

> +------------
> +
> +* Configure a 'sign' trailer with a command to automatically add a
> +  'Signed-off-by: ' with the author information only if there is no
> +  'Signed-off-by: ' already, and show how it works:
> ++
> +------------
> +$ git config trailer.sign.key "Signed-off-by: "
> +$ git config trailer.sign.ifmissing add
> +$ git config trailer.sign.ifexists doNothing
> +$ git config trailer.sign.command 'echo "$(git config user.name) <$(git config user.email)>"'
> +$ git interpret-trailers <<EOF
> +> EOF

How to configure git-interpret-trailers command so that it follow
current rules for DCO:
* Signed-off-by: is always at bottom; we can have
   signoff+signoff+ack+signoff
* Signed-off-by: can repeat itself with the same author;
   this denotes steps in coming up with current version of the patch.
* but we shouldn't repeat the same signoff one after another

So we want to allow this:

   Signed-off-by: A U Thor <author@example.com>
   Signed-off-by: Joe R. Hacker <joe@hacker.com>
   Acked-by: D E Veloper <developer@example.com>
   Signed-off-by: C O Mitter <committer@example.com>

but prevent this

   Signed-off-by: C O Mitter <committer@example.com>
   Signed-off-by: C O Mitter <committer@example.com>


IIRC
-- 
Jakub Narębski

  parent reply	other threads:[~2014-06-30 11:57 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-25  5:32 [PATCH v12 00/11] Add interpret-trailers builtin Christian Couder
2014-05-25  5:32 ` [PATCH v12 01/11] trailer: add data structures and basic functions Christian Couder
2014-05-25  5:32 ` [PATCH v12 02/11] trailer: process trailers from input message and arguments Christian Couder
2014-05-25  5:32 ` [PATCH v12 03/11] trailer: read and process config information Christian Couder
2014-05-25  5:32 ` [PATCH v12 04/11] trailer: process command line trailer arguments Christian Couder
2014-05-25  5:32 ` [PATCH v12 05/11] trailer: parse trailers from file or stdin Christian Couder
2014-05-25  5:32 ` [PATCH v12 06/11] trailer: put all the processing together and print Christian Couder
2014-05-25  5:32 ` [PATCH v12 07/11] trailer: add interpret-trailers command Christian Couder
2014-05-25  5:32 ` [PATCH v12 08/11] trailer: add tests for "git interpret-trailers" Christian Couder
2014-05-28 19:28   ` Junio C Hamano
2014-05-25  5:32 ` [PATCH v12 09/11] trailer: execute command from 'trailer.<name>.command' Christian Couder
2014-05-25  5:32 ` [PATCH v12 10/11] trailer: add tests for commands in config file Christian Couder
2014-05-25  5:32 ` [PATCH v12 11/11] Documentation: add documentation for 'git interpret-trailers' Christian Couder
2014-05-28 19:35   ` Junio C Hamano
2014-06-29  9:37     ` Christian Couder
2014-06-30  6:40       ` Junio C Hamano
2014-05-28 19:44   ` Junio C Hamano
2014-06-30 11:57   ` Jakub Narębski [this message]
2014-07-01 13:34     ` Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B150B4.1030303@gmail.com \
    --to=jnareb@gmail.com \
    --cc=chriscool@tuxfamily.org \
    --cc=dan.carpenter@oracle.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=greg@kroah.com \
    --cc=johan@herland.net \
    --cc=josh@joshtriplett.org \
    --cc=jrnieder@gmail.com \
    --cc=mhagger@alum.mit.edu \
    --cc=peff@peff.net \
    --cc=ramsay@ramsay1.demon.co.uk \
    --cc=sunshine@sunshineco.com \
    --cc=tr@thomasrast.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).