git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Torsten Bögershausen" <tboegi@web.de>
To: Jeff King <peff@peff.net>, Paul Eggert <eggert@cs.ucla.edu>
Cc: git@vger.kernel.org
Subject: Re: git format-patch doesn't add Content-type for UTF-8 diffs
Date: Tue, 01 Jul 2014 06:38:24 +0200	[thread overview]
Message-ID: <53B23B40.1070209@web.de> (raw)
In-Reply-To: <20140630173052.GB16747@sigill.intra.peff.net>


>I wonder if it would be enough to do:

>  1. Always add a content-type header, even if the commit is utf-8 and
>     contains only ascii characters. This _shouldn't_ hurt anything,
>     though I suppose it would if you have latin1 (for example) commit
>     messages and did not correctly set the encoding header in your
>     commits.

Does it make sense to call this function (from utf8.c)

int is_utf8(const char *text)

and either add the content-type header for utf-8 (or not)

      parent reply	other threads:[~2014-07-01  4:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-30  9:03 git format-patch doesn't add Content-type for UTF-8 diffs Paul Eggert
2014-06-30 17:30 ` Jeff King
2014-06-30 18:54   ` Paul Eggert
2014-07-01  4:38   ` Torsten Bögershausen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B23B40.1070209@web.de \
    --to=tboegi@web.de \
    --cc=eggert@cs.ucla.edu \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).