git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Elliot Wolk <elliot.wolk@gmail.com>
To: Robin Rosenberg <robin.rosenberg@dewire.com>
Cc: git@vger.kernel.org
Subject: Re: move detection doesnt take filename into account
Date: Tue, 01 Jul 2014 10:40:48 -0400	[thread overview]
Message-ID: <53B2C870.4030406@gmail.com> (raw)
In-Reply-To: <287177519.16421.1404206204124.JavaMail.zimbra@dewire.com>

interesting that it considers suffixes {only suffixes following 
periods?}. this is insufficient, in my opinion.

with all other things being equal, it ought to find the closest match 
{using smith-waterman or some such algorithm}.

as a real-world use case, i have a repository with empty files that 
mirrors the file structure of a directory containing large binary files.
when i move a dir, it seems to select the files renamed at random.

On 07/01/2014 05:16 AM, Robin Rosenberg wrote:
>
> ----- Ursprungligt meddelande -----
>> Från: "Elliot Wolk" <elliot.wolk@gmail.com>
>> Till: git@vger.kernel.org
>> Skickat: måndag, 30 jun 2014 8:38:18
>> Ämne: move detection doesnt take filename into account
>>
>> if you move two identical {e.g.: empty} files to two new locations in a
>> single commit, the move detection picks them {seemingly?} arbitrarily.
>> it should use a statistical algorithm to compare the filenames and pick
>> a likely match.
> I think it does, but based on filename suffix. E.g. here is a rename of
> three empty files with a suffix.
>
>   3 files changed, 0 insertions(+), 0 deletions(-)
>   rename 1.a => 2.a (100%)
>   rename 1.b => 2.b (100%)
>   rename 1.c => 2.c (100%)
>
> -- robin

  reply	other threads:[~2014-07-01 14:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-30  6:38 move detection doesnt take filename into account Elliot Wolk
2014-07-01  9:16 ` Robin Rosenberg
2014-07-01 14:40   ` Elliot Wolk [this message]
2014-07-01 14:57   ` Junio C Hamano
2014-07-01 15:05     ` Elliot Wolk
2014-07-01 17:08       ` Junio C Hamano
2014-07-09  6:45         ` Jeff King
2014-07-09 15:51           ` Junio C Hamano
2014-07-09 22:03             ` Jeff King
2014-07-09 22:18               ` Junio C Hamano
2014-07-10  3:53                 ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B2C870.4030406@gmail.com \
    --to=elliot.wolk@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=robin.rosenberg@dewire.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).