From: Avi Kivity <avi@cloudius-systems.com>
To: "Torsten Bögershausen" <tboegi@web.de>, git@vger.kernel.org
Subject: Re: [PATCH v2] git-am: add option to extract email Message-Id: tag into commit log
Date: Wed, 02 Jul 2014 16:54:12 +0300 [thread overview]
Message-ID: <53B40F04.8000304@cloudius-systems.com> (raw)
In-Reply-To: <53B3D7AB.6090207@web.de>
On 07/02/2014 12:58 PM, Torsten Bögershausen wrote:
>> @@ -757,6 +761,10 @@ To restore the original branch and stop patching run \"\$cmdline --abort\"."
>> then
>> cat "$dotest/msg-clean"
>> fi
>> + if test 't' == "$message_id"
> The == is bash special, please use = instead
> And the 't' can be written as t, so that the whole line looks like this:
> if test t = "$message_id"
>
Thanks. v3 posted with these changes.
next prev parent reply other threads:[~2014-07-02 13:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 8:51 [PATCH v2] git-am: add option to extract email Message-Id: tag into commit log Avi Kivity
2014-07-02 9:58 ` Torsten Bögershausen
2014-07-02 13:54 ` Avi Kivity [this message]
2014-07-02 14:18 ` Fabian Ruch
2014-07-02 14:44 ` Avi Kivity
2014-07-02 17:17 ` Junio C Hamano
2014-07-03 14:08 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B40F04.8000304@cloudius-systems.com \
--to=avi@cloudius-systems.com \
--cc=git@vger.kernel.org \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).