From: Avi Kivity <avi@cloudius-systems.com>
To: "Torsten Bögershausen" <tboegi@web.de>, git@vger.kernel.org
Subject: Re: [PATCH v4] git-am: add option to extract email Message-Id: tag into commit log
Date: Wed, 02 Jul 2014 19:15:29 +0300 [thread overview]
Message-ID: <53B43021.9090506@cloudius-systems.com> (raw)
In-Reply-To: <53B41F28.8040205@web.de>
On 07/02/2014 06:03 PM, Torsten Bögershausen wrote:
>> @@ -565,6 +568,7 @@ Use \"git am --abort\" to remove it.")"
>> echo " $git_apply_opt" >"$dotest/apply-opt"
>> echo "$threeway" >"$dotest/threeway"
>> echo "$sign" >"$dotest/sign"
>> + echo "$message_id" >"$dotest/message-id"
>> echo "$utf8" >"$dotest/utf8"
>> echo "$keep" >"$dotest/keep"
>> echo "$scissors" >"$dotest/scissors"
>> @@ -651,6 +655,10 @@ then
>> else
>> SIGNOFF=
>> fi
>> +if test "$(cat "$dotest/message-id")" = t
> Does the usage of '"' inside of '"' look good, or can we write like this:
> if test $(cat "$dotest/message-id") = t
With your change, it will fail if the file is missing or empty.
Complex shell scripts cannot be made to look good. If that's a
requirement then the script should be rewritten in a reasonable language.
prev parent reply other threads:[~2014-07-02 16:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 14:51 [PATCH v4] git-am: add option to extract email Message-Id: tag into commit log Avi Kivity
2014-07-02 15:03 ` Torsten Bögershausen
2014-07-02 16:15 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B43021.9090506@cloudius-systems.com \
--to=avi@cloudius-systems.com \
--cc=git@vger.kernel.org \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).